Skip to content

[MNT] Mark tsfresh estimators non-deterministic for multithreading tests #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amiirhosseini wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MNT] Mark tsfresh estimators non-deterministic for multithreading tests #3770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aeon/classification/feature_based/_fresh_prince.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ class FreshPRINCEClassifier(BaseClassifier):
"capability:multithreading": True,
"capability:train_estimate": True,
"algorithm_type": "feature",
"non_deterministic": True,
"python_dependencies": "tsfresh",
}

Expand Down
1 change: 1 addition & 0 deletions aeon/classification/feature_based/_tsfresh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ class TSFreshClassifier(BaseClassifier):
"capability:multithreading": True,
"capability:unequal_length": True,
"algorithm_type": "feature",
"non_deterministic": True,
"python_dependencies": "tsfresh",
}

Expand Down
1 change: 1 addition & 0 deletions aeon/clustering/feature_based/_tsfresh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ class TSFreshClusterer(BaseClusterer):
"capability:multithreading": True,
"capability:unequal_length": True,
"algorithm_type": "feature",
"non_deterministic": True,
"python_dependencies": "tsfresh",
}

Expand Down
1 change: 1 addition & 0 deletions aeon/regression/feature_based/_fresh_prince.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ class FreshPRINCERegressor(BaseRegressor):
"capability:multithreading": True,
"capability:train_estimate": True,
"algorithm_type": "feature",
"non_deterministic": True,
"python_dependencies": "tsfresh",
}

Expand Down
1 change: 1 addition & 0 deletions aeon/regression/feature_based/_tsfresh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ class TSFreshRegressor(BaseRegressor):
"capability:multithreading": True,
"capability:unequal_length": True,
"algorithm_type": "feature",
"non_deterministic": True,
"python_dependencies": "tsfresh",
}

Expand Down
9 changes: 0 additions & 9 deletions aeon/testing/testing_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,6 @@
# broken by 0.63.0 numba update, see #3307 attempt to fix
"HIVECOTEV2": ["check_classifier_against_expected_results"],
"TemporalDictionaryEnsemble": ["check_classifier_against_expected_results"],
# multithreading issue, sometimes produces different results between single
# and multithreading
"FreshPRINCEClassifier": ["check_estimator_multithreading"],
"FreshPRINCERegressor": ["check_estimator_multithreading"],
"TSFreshClassifier": ["check_estimator_multithreading"],
"TSFreshRegressor": ["check_estimator_multithreading"],
"TSFreshClusterer": ["check_estimator_multithreading"],
"TSFreshRelevant": ["check_estimator_multithreading"],
"TSFresh": ["check_estimator_multithreading"],
}
Comment on lines 61 to 64

# Exclude specific tests for estimators here only when numba is disabled
Expand Down
1 change: 1 addition & 0 deletions aeon/transformations/collection/feature_based/_tsfresh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class _TSFresh(BaseCollectionTransformer):
"capability:multithreading": True,
"capability:unequal_length": True,
"fit_is_empty": True,
"non_deterministic": True,
"python_dependencies": "tsfresh",
Comment on lines 44 to 48
}

Expand Down
Loading