Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary
Normalizes ISO-style dates submitted or scanned as a book's publish year to a four-digit year.
Which issue is fixed?
Fixes #2270
In-depth Description
The scanner normalizes metadata after source precedence is resolved. Manual metadata edits now accept ISO dates and the server normalizes them before persisting, so API clients follow the same rule.
Only values beginning with
YYYYorYYYY-are normalized.publishedDateis unchanged.How have you tested this?
npm test(359 passing)2013-02-01in Publish Year and confirmed the saved value is2013Screenshots
Not included; this is a small metadata edit field behavior change.