fix(llmo-customer-analysis): create brand-presence schedule via shared drs-client helper | LLMO-5605

[igor-grubic]

1. Abstract

Migrates the llmo-customer-analysis onboarding cascade's brand-presence schedule creation from an inline fetch payload to the shared createBrandPresenceSchedule drs-client helper. Behaviour-preserving.

2. Reasoning

Anti-drift. This makes the cascade use the single definition of the brand-presence schedule, shared with the self-serve activate-brand endpoint (spacecat-api-service, LLMO-5605). DRS dedups schedules on the provider-set (site_id, brand_id, cadence, provider-set), so two hand-synced payloads in two repos would eventually drift and silently produce duplicate schedules. One helper both paths call removes that class of bug.

3. High-level overview of the changes

• src/llmo-customer-analysis/handler.js: brand-presence schedule creation now routes through @adobe/spacecat-shared-drs-client's createBrandPresenceSchedule (POST + tolerate 409) instead of an inline /schedules + /trigger fetch.
• Behaviour-preserving: same weekly cadence, provider set (brightdata / google_ai_overviews / openai_web_search), enable_brand_presence, and immediate trigger.
• Legacy no-op fields dropped (a camelCase siteId and a platforms array in provider_parameters) — verified unread by DRS (the scheduler copies provider_parameters verbatim into the job, but brightdata consumes only dataset_id + metadata.site).
• Bumps @adobe/spacecat-shared-drs-client 1.12.1 → 1.13.0 (the release that adds the helper).

4. Required information

• Jira / issue: LLMO-5605 — https://jira.corp.adobe.com/browse/LLMO-5605
• Spec: Piece 2 design spec — https://github.com/adobe/project-elmo-ui/issues/2095
• Other: Piece 1 spec — https://github.com/adobe/project-elmo-ui/issues/2092

5. Affected / used mysticat-workspace projects

• spacecat-shared (drs-client) — consumed: depends on createBrandPresenceSchedule from 1.13.0 — feat(drs-client): add listJobs + createBrandPresenceSchedule | LLMO-5605 spacecat-shared#1721.
• spacecat-api-service — contract / coordinated: the activate endpoint (feat(brands): self-serve activate-brand endpoint | LLMO-5605 spacecat-api-service#2706) and this cascade share the same helper definition; both must route through it so the DRS provider-set dedup keeps matching.

7. Test plan

(a) Local — tests reworked to assert the createBrandPresenceSchedule helper call (args + returned scheduleId) instead of the raw /schedules + /trigger fetches.

(b) Per-env (dev): run the llmo-customer-analysis onboarding for a site → confirm exactly one weekly brand-presence schedule is created in DRS (same cadence / provider-set as before) with the immediate trigger firing; re-run → confirm idempotency (DRS 409 tolerated, no duplicate schedule).

8. Deployment & merge order

Part of the LLMO-5605 Piece 2 chain. Anti-drift migration, parallel with the api-service endpoint.

• drs-client 1.13.0 (spacecat-shared) — released: provides the helper — feat(drs-client): add listJobs + createBrandPresenceSchedule | LLMO-5605 spacecat-shared#1721.
• This PR (spacecat-audit-worker) — migrates the cascade to the helper; can merge independently now the dependency is released.
• spacecat-api-service activate endpoint — related (parallel anti-drift): must use the same helper — feat(brands): self-serve activate-brand endpoint | LLMO-5605 spacecat-api-service#2706.

Ordered sequence: drs-client 1.13.0 released (done) → this PR and the api-service endpoint each merge; both must stay on the shared helper to preserve dedup.

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[MysticatBot]

Hey @igor-grubic,

Verdict: Approve - clean behaviour-preserving migration to the shared drs-client helper.
Complexity: HIGH - large patch (mostly deletions); dependency bump.
Changes: Migrates brand-presence schedule creation from inline fetch logic to the shared createBrandPresenceSchedule drs-client helper, eliminating drift risk between the audit-worker and api-service paths (4 files).

Non-blocking (2): minor issues and suggestions

• suggestion: Tighten the error-message assertion in "should handle brand presence schedule creation failure" to include the DRS error text suffix (e.g. sinon.match(/Failed to create\/trigger.*DRS API error/)) so loss of error context propagation would be caught - test/audits/llmo-customer-analysis.test.js
• suggestion: Add calledWithMatch({ siteId: 'site-123', triggerImmediately: true }) to the "already existed" test for parity with other brand-presence-schedule tests - test/audits/llmo-customer-analysis.test.js

---

_{Skill: pr-review | Model: us.anthropic.claude-opus-4-6-v1[1m] | Duration: 1m 27s | Cost: $4.68 | Commit: 41c481f310102e7906ed5bee0fb3689637061be6
If this code review was useful, please react with 👍. Otherwise, react with 👎.}