-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: #9239 Focus on the first available option in the dropdown #10236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jsmitrah
wants to merge
12
commits into
adobe:main
from
jsmitrah:fix/9239/focus-on-the-first-available-option
+52
−4
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2982af3
fix: added fix to focused on the first available option on the dropdown.
jsmitrah 4499fcd
Merge branch 'main' into fix/9239/focus-on-the-first-available-option
jsmitrah 0fa95c8
fix: updated the test case.
jsmitrah 716a6de
fix: updated the test case.
jsmitrah 49627aa
fix: added condition to handle the disabled options.
jsmitrah 1e705e6
Merge branch 'main' into fix/9239/focus-on-the-first-available-option
jsmitrah eb84341
Merge branch 'main' into fix/9239/focus-on-the-first-available-option
jsmitrah 44e67b4
Merge branch 'main' into fix/9239/focus-on-the-first-available-option
jsmitrah 9502c69
fix: modified the condition to make include that while testing and re…
jsmitrah 7b72c16
fix: added condition to avoid infinite loop.
jsmitrah 1a97e01
fix: safely bypass disabled keys on autofocus mount
jsmitrah bb7d915
Merge branch 'main' into fix/9239/focus-on-the-first-available-option
jsmitrah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something is wrong the tests, they pass without this change as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, this block was redundant, so I have removed it and reverted this section.