Migrated Config Overrides functional tests to Vitest+Playwright+MSW#1538
Migrated Config Overrides functional tests to Vitest+Playwright+MSW#1538carterworks wants to merge 5 commits into
Conversation
|
|
| Filename | Overview |
|---|---|
| packages/browser/test/integration/specs/Config Overrides/configOverridesPayload.spec.js | New integration spec migrating 4 TestCafe files (C7437530–C7437533) to Vitest+Playwright+MSW; all 22 scenarios are structurally correct but the empty config override values tests for getIdentity, appendIdentityToUrl, and setConsent omit positive assertions, leaving a gap compared to the originals. |
Sequence Diagram
sequenceDiagram
participant Test as Vitest Test
participant Alloy as Alloy SDK (Browser)
participant MSW as MSW Worker
participant NR as NetworkRecorder
Test->>Alloy: configure(alloyConfig [+ edgeConfigOverrides])
Test->>Alloy: sendEvent / getIdentity / appendIdentityToUrl / setConsent [+ edgeConfigOverrides]
Alloy->>MSW: POST /v1/interact (or /acquire, /set-consent) with meta.configOverrides merged
MSW-->>Alloy: Mocked response (200)
Alloy-->>Test: Command resolves
Test->>NR: findCall(urlRegex)
NR-->>Test: Recorded request
Test->>Test: "expect(meta.configOverrides.*) assertions"
Reviews (2): Last reviewed commit: "test(integration): migrate config overri..." | Re-trigger Greptile
2fb56e2 to
e183d80
Compare
fe8d1b8 to
15655d5
Compare
e183d80 to
8aa9f6b
Compare
15655d5 to
c1b8db1
Compare
There was a problem hiding this comment.
carterworks has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
carterworks has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
b0138f0 to
a378e25
Compare
a378e25 to
597c00f
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…arity Several 'from configure', 'takes precedence', and 'empty values' tests were only asserting 1-2 override fields. Bring all four suites (sendEvent, getIdentity, appendIdentityToUrl, setConsent) to parity with the original TestCafe tests by asserting all four override fields: com_adobe_experience_platform, com_adobe_analytics, com_adobe_identity, and com_adobe_target.
ca06bde to
e8e2e7d
Compare
Keep the original testcafe functional specs alongside the new Vitest+Playwright+MSW integration suite until these migration branches merge, so reviewers retain the pre-migration signal.
Changed Packages
Description
Migrates the Config Overrides functional tests to the new Vitest+Playwright+MSW harness.
Related Issue
Part of the functional test → integration test migration. See
packages/browser/test/FUNCTIONAL_MIGRATION_PLAN.md.Motivation and Context
The existing TestCafe functional test suite is being migrated to Vitest+Playwright+MSW to enable faster, more reliable CI testing without a running server. This PR is part of a stacked series — each PR migrates one test file.
Functional tests replaced:
packages/browser/test/functional/specs/Config Overrides/C7437530.jspackages/browser/test/functional/specs/Config Overrides/C7437531.jspackages/browser/test/functional/specs/Config Overrides/C7437532.jspackages/browser/test/functional/specs/Config Overrides/C7437533.jsTypes of changes
Checklist:
Stack