Add support to Asterisk renderer to say numbers.

[ssether-usinternet]

This patch makes changes to the Asterisk media renderer to add support for saying numbers using the SayNumber AGI command of Asterisk. Previously only playing audio files was supported for this renderer.

I've added rspec tests for this new behavior, and changed any rspec tests that now behave slightly differently.

This has been tested on Asterisk 11.

[coveralls]

Coverage decreased (-0.8%) to 98.243% when pulling 89ba718 on ssether-usinternet:develop into 466192a on adhearsion:develop.

[ssether-usinternet]

@benlangfeld It's been a couple weeks now. Can you look at this request? We're using this for our internal project, and we'd prefer it is merged into the main project rather than have to maintain a separate version for ourself.

[lpradovera]

@ssether-usinternet Should this not be part of adhearsion-asterisk? Also keep in mind Punchblock is no longer a separate gem in Adhearsion 3.

[ssether-usinternet]

@lpradovera We're using Adhearsion 2.6.4, primarily because it doesn't look like Adhearsion 3 is production quality. I only see a rc1 release, but not a proper full release of Adhearsion 3. Also, when we started this project all the documentation was for 2.6. I'm not certain if there's any documentation for 3 or not.

I'm not sure why we'd want to put this in adhearsion-asterisk. This patch merely builds upon the already existing support for playing audio files, and adds the ability to play numbers.

We'd consider switching to 3.0 if it's ready for production. We started this project on the 2.6 branch because we wanted to be on something that was stable and maintained. We're about ready to move our project forward into semi-production, so I wouldn't want to de-stabilize it at this point and move to 3.0.

I'd certainly port this over to 3.0 if that helps, but for our current release we need to support the 2.6 branch in the short term.

[benlangfeld]

I’m not actively involved in maintaining Adhearsion these days. I’ll leave this to Luca.

[chewi]

For the record, my company has been using Adhearsion 3 in production for over a year now on behalf of some household names, though admittedly we're using FreeSWITCH rather than Adhearsion. There has been the odd issue but I've fixed all the ones I've found.

[lpradovera]

@ssether-usinternet I agree, and besides, Punchblock is 2.6-only anyways. I think this LGTM!