Fix <S^2> for frozen_core References - #238
Merged
Merged
Conversation
jonasleitner
force-pushed
the
ssq_frozen_core
branch
from
August 17, 2026 12:28
eda3b34 to
1098273
Compare
Co-authored-by: Friederike Schneider <110526409+frieschneider@users.noreply.github.com>
frieschneider
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<S^2> was wrong for any
ReferenceStatewithfrozen_core."Normal" and
frozen_virtualreferences were not affected.This was a consequence of missing blocks in
ReferenceState.density_2pandOperatorIntegrals.ssq_2p.Changes:
density_2pandssq_2p. Note: the operator should most likely be also valid for CVS, but could not test it without CVS 2p densities and thus kept theNotImplementedErrorin place.ReferenceStateandLazyMp<S^2> tests were updated to cover all cases to catch this in the future.ssqdata.