refactor: Rename TrackFitterPerformance to TrackParameterPerformance - #5841
Merged
kodiakhq[bot] merged 2 commits intoAug 11, 2026
Merged
Conversation
github-actions
Bot
added
Infrastructure
andiwand
changed the title
andiwand
force-pushed
the
rename-track-parameter-performance-writer
branch
from
August 7, 2026 11:41
9da1176 to
0210186
Compare
Contributor
Public API surface diffNo change to the public API surface. ✅ |
Contributor
`RootTrackFitterPerformanceWriter` compares the track parameters at the track reference surface to truth. Nothing in that is specific to a fitter, the same comparison applies to a seed estimate, so the name is widened: - `TrackFitterPerformanceCollector` -> `TrackParameterPerformanceCollector` - `RootTrackFitterPerformanceWriter` -> `RootTrackParameterPerformanceWriter` - `PythonTrackFitterPerformanceWriter` -> `PythonTrackParameterPerformanceWriter` The old python names stay as deprecated aliases, as done for `TrackFinderPerformanceWriter` in acts-project#5775. `ResPlotTool::Config::paramNames` becomes settable from python, since `d0`/`z0` only hold on a perigee. No histogram changes, so the physmon references stay valid. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxPc2jP43AQuQKz8c4qsaC
andiwand
marked this pull request as ready for review
August 11, 2026 07:31
andiwand
force-pushed
the
rename-track-parameter-performance-writer
branch
from
August 11, 2026 07:31
0210186 to
a94b76c
Compare
paulgessinger
approved these changes
Aug 11, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RootTrackFitterPerformanceWritercompares the track parameters at the trackreference surface to truth. Nothing in that is specific to a fitter, the same
comparison applies to a seed estimate, so the name is widened:
TrackFitterPerformanceCollector->TrackParameterPerformanceCollectorRootTrackFitterPerformanceWriter->RootTrackParameterPerformanceWriterPythonTrackFitterPerformanceWriter->PythonTrackParameterPerformanceWriterThe old python names stay as deprecated aliases, as done for
TrackFinderPerformanceWriterin #5775.ResPlotTool::Config::paramNamesbecomes settable from python, sinced0/z0only hold on a perigee.
No histogram changes, so the physmon references stay valid.
--- END COMMIT MESSAGE ---
Split out of #5721. Review order:
SeedsToTracksTrackExtrapolationAlgorithmaddSeeding1 to 3 are independent of each other, 4 needs all of them. All of them target
main, so the diff of 4 contains 1 to 3 until they merge. #5846 is a smallfix found along the way and is independent of all of these.
Not breaking: only
Examples,PythonandCIare touched, and the oldpython names keep working through the deprecated aliases.
Migration
The default
filePathbecomesperformance_track_parameters.root. Every callsite in the repository sets it explicitly.
Validation
Next to the renames the diff carries only doc comments, one log string and the
two additions above, so no histogram name or content can change. The python
test suite gives the same set of failures as
mainon the same machine.