feat(detray): Bind material validation - #5832
Draft
VladimirDrobny wants to merge 14 commits into
Draft
Conversation
Contributor
Public API surface diffNo change to the public API surface. ✅ |
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to replace the material_validation.cpp tool script.
For this, it binds the detector and gives access to its data.
A lot of complexity comes from replacing the argument parsing and processing. Instead of using Boost and its variables_map for input, the current Python toolchain uses argparse.
The new bindings handle the argparse dict faithfully to the C++ implementation.
Many C++ functions use configuration structs, which are "automatically" populated from the parsed args beforehand.
The Python bindings provide full access to the config structs. Helper Python-side functions are provided to fill the structs.
--- END COMMIT MESSAGE ---
The submodules where the config structs are placed, along with the CMake options under which they are bound, are WIP.