perf: Optional recording of CKF material track states - #5827
Open
andiwand wants to merge 3 commits into
Open
Conversation
Adds `recordMaterialStates` to the CKF options. When disabled, surfaces with material but no sensitivity no longer get a track state. Material effects are still applied, only the record is dropped. The transport jacobian of a skipped surface is folded into the next recorded state, so the MultiTrajectory contract that a state's jacobian runs from the previous state is preserved and smoothing is unaffected. Defaults to true, so nothing changes unless opted out. Ignored with a multi-component stepper, which has no single jacobian to fold. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QpujVemBhQ8SiNQPsfeWhj
github-actions
Bot
added
Component - Core
Contributor
Public API surface diff+3 added, 0 breaking. ➕ Added public APINew public data members (3)
|
Contributor
Disabling `recordMaterialStates` with a multi-component stepper now throws instead of logging a warning per `findTracks` call. `TrackFindingAlgorithm` shares one options object between the plain and the bremsstrahlung finder and picks the finder per seed, so every electron seed took that path. The brem finder now gets its own options with the recording kept enabled. Also shortens the comments and turns the test helper into a fixture member. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WSzhTpwpLH3BkzdvjnB2Xo
|
Contributor
|
I have tested this with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
recordMaterialStatesto the CKF options. When disabled, surfaces with material but no sensitivity no longer get a track state. Material effects are still applied, only the record is dropped.The transport jacobian of a skipped surface is folded into the next recorded state, so the MultiTrajectory contract that a state's jacobian runs from the previous state is preserved and smoothing is unaffected.
Defaults to true, so nothing changes unless opted out. Ignored with a multi-component stepper, which has no single jacobian to fold.
--- END COMMIT MESSAGE ---
Motivation: these states are never a measurement, hole or outlier, and are trimmed away again in the Examples chain. They still cost a bound state, a track state allocation and a branch stopper call each, and the smoother walks them.
Measured on ODD ttbar pu200, single thread, n=30,
Algorithm:TrackFindingAlgorithmper event:With the flag on, seed, track and branch counts are identical to main.
Two things worth knowing before turning it off:
DirectNavigatortakes its surface sequence from the track states, so it needs the flag left on.New tests cover that the product of stored jacobians and the smoothed parameters at the measurement surfaces agree with and without recording, for both
GainMatrixSmootherandMbfSmoother.CubicTrackingGeometryhas no material-only surfaces, hence the small telescope geometry in the test.