fix(cmake): avoid actsvg C++ standard cache leak - #5817
Open
shuv-amp wants to merge 1 commit into
Open
Conversation
ActSVG caches CMAKE_CXX_STANDARD=17, causing the next configure to fail. Remove the cache entry after loading ActSVG if it did not exist before. Add a CI check that configures ACTS with ActSVG twice. Closes acts-project#4952
github-actions
Bot
added
the
Infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActSVG caches
CMAKE_CXX_STANDARD=17, which causes a second configurein the same build directory to fail. Remove the cache entry after loading
ActSVG if it was not present before, leaving an existing value unchanged.
Add a CI check that configures ACTS with ActSVG twice.
Closes #4952
Tested repeated configuration with the default standard and with C++23,
and ran the ActSVG converter tests.