Conversation
…p and BtnActionAdd components
…ponents - Created tests for CardChangeAccountInfo and its subcomponents (Email, Password, Username) to ensure proper rendering and functionality. - Implemented tests for CardConnect and its related components (Event, Group, Organization) to validate social link rendering and modal interactions. - Added tests for CardDiscussion and its entries, including input handling and rendering of discussion details. - Developed tests for dropdown components (DropdownCreate, DropdownDateFilter, DropdownInfo, DropdownLanguage, DropdownUserOptions) to verify menu interactions and options rendering. - Ensured all tests check for correct labels, aria attributes, and user interactions.
…ents, and form selectors
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Thank you for the pull request! ❤️The activist team will do our best to address your contribution as soon as we can. The following are some important points:
Note activist uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Hi @LucasEdwa 👋 Thanks for your interest in the project :) Would you be able to rebase main? |
nicki182
left a comment
nicki182
left a comment
There was a problem hiding this comment.
praise: thank you for this PR. Just put back some files to its original state and it should be fine and the test files created based on them you can remove them, we will create them when they are properly implemented
There was a problem hiding this comment.
please put back the changes from this file. Its a component not being used but will be
There was a problem hiding this comment.
same here, please return the file on the previous state
| </p> | ||
| <div class="mt-1 flex gap-10 sm:mt-0 sm:flex-col sm:gap-0"> | ||
| <template v-for="(connect, index) in links.connectLinks"> | ||
| <!-- aria-label uses `connect.ariaLabel`, not `connect.name` (the |
There was a problem hiding this comment.
remove this comment, its too long and unnecessary
|
Please let us know if you need support finalizing this PR, @LucasEdwa! |
3 participants
Summary
Card*components (change-account-info, connect, discussion, about, and standalone cards), dropdown components,ComboboxTopics, andDiscussion/DiscussionHeader.Feed,FeedItem,FooterWebsite,Events*components, andFormSelectorCombobox*selectors.=vs===) inFeedItem.vuethat made the PEOPLE icon always render, and an incorrectaria-labelbinding inFooterWebsite.vuethat used the visible link name instead of each link's dedicatedariaLabel.Test plan
frontend/test/components/**unit tests added/pass locally via Vitest