Skip to content

feat: global dashboard export ops type column and filter - #3364

Merged
Seechi-Yolo merged 5 commits into
mainfrom
sqle/feat-3090
Aug 21, 2026
Merged

feat: global dashboard export ops type column and filter#3364
Seechi-Yolo merged 5 commits into
mainfrom
sqle/feat-3090

Conversation

@LordofAvernus

@LordofAvernus LordofAvernus commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

User description

关联的 issue

https://github.com/actiontech/sqle-ee/issues/3090

描述你的变更

  • 三套全局导出布局补齐「运维类型」列与行字段,并覆盖单测;项目内布局冻结
  • ExportGlobalWorkflowReqV2 增加可选 filter_by_ops_type_uid
  • 同步 swagger / OpenAPI 生成物

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc


Description

  • 在请求结构体中新增 FilterByOpsTypeUID 字段

  • 更新 API 文档及 swagger 定义说明

  • 导出逻辑中添加 ops type 信息映射

  • 增加 CE 模式下的空实现及测试更新


Diagram Walkthrough

flowchart LR
  A["新增 FilterByOpsTypeUID 参数"]
  B["更新 API 文档与 swagger"]
  C["导出函数中增加 ops type 处理"]
  D["添加 CE 模式空实现和测试"]
  A -- "影响请求解析" --> B
  B -- "联动导出更新" --> C
  C -- "验证测试覆盖" --> D
Loading

File Walkthrough

Relevant files
Enhancement
3 files
workflow_manage.go
添加 FilterByOpsTypeUID 参数及注释说明                                                       
+3/-0     
export.go
导出函数中集成 ops type 信息映射                                                                       
+35/-2   
export_list_ops_type_ce.go
添加 CE 模式下 ops type 空实现                                                                     
+11/-0   
Documentation
3 files
docs.go
增加 swagger 参数描述和文档更新                                                                         
+6/-7     
swagger.json
更新 swagger.json 中 ops type 定义                                                       
+6/-7     
swagger.yaml
更新 swagger.yaml 增加 ops type 参数                                                     
+5/-5     
Tests
1 files
export_test.go
更新测试,验证导出列中 ops type                                                                         
+93/-5   

LordofAvernus and others added 3 commits August 20, 2026 18:25
Insert WFExportOpsType into Common/SQLRelease/DataExport global headers
and row builders; keep project layout frozen and prune empty optional cols.

Co-authored-by: Cursor <cursoragent@cursor.com>
Extend ExportGlobalWorkflowReqV2 with optional query so export filtering
aligns with the global workflow list.

Co-authored-by: Cursor <cursoragent@cursor.com>
Regenerate OpenAPI artifacts for filter_by_ops_type_uid on dashboard export.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

PR Reviewer Guide 🔍

(Review updated until commit 154e36f)

🎫 Ticket compliance analysis ✅

3090 - Fully compliant

Compliant requirements:

  • 新增 FilterByOpsTypeUID 字段并在请求结构体中实现
  • 更新 API 文档、swagger.json 和 swagger.yaml 添加运维类型相关描述
  • 在导出逻辑中添加 ops type 映射及展示,并通过单元测试验证
⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
修正多行描述格式

建议将该多行描述合并为单行字符串或使用 YAML 折叠语法来保证描述内容格式正确,避免可能的解析错误。检查缩进与格式与其他参数保持一致。

sqle/docs/swagger.yaml [15782-15786]

-- description: filter by ops type dictionary item uid; empty means no filter;
-    applies to sql_release and data_export; same semantics as GET /v2/dashboard/workflows
+- description: "filter by ops type dictionary item uid; empty means no filter; applies to sql_release and data_export; same semantics as GET /v2/dashboard/workflows"
   in: query
   name: filter_by_ops_type_uid
   type: string
Suggestion importance[1-10]: 5

__

Why: The suggestion consolidates the multi-line description for filter_by_ops_type_uid into a single quoted string, ensuring consistent YAML formatting and reducing the risk of parsing errors.

Low

CE vendor ListDataExportWorkflow has no OpsType field; move name
resolution to a !enterprise stub so shared export.go typechecks.
@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit dc3e3ae

Replace the mismatched swagger.json dump with the repo swag output so docs.go, swagger.json, and swagger.yaml stay consistent.
@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit 154e36f

@Seechi-Yolo
Seechi-Yolo merged commit 7a71810 into main Aug 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants