feat: skip immediate first collect on scan task start - #3356
Closed
LordofAvernus wants to merge 1 commit into
Closed
LordofAvernus wants to merge 1 commit into
LordofAvernus wants to merge 1 commit into
Conversation
Remove extractSQL() at TaskWrapper.loop entry so restart/rebuild only registers the ticker; first collect waits for the period tick. Fixes actiontech/sqle-ee#3053 Co-authored-by: Cursor <cursoragent@cursor.com>
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Collaborator
Author
基线纠正本 PR 目标分支 关闭本 PR,改走 sqle-ee 客户分支 PR。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/sqle-ee/issues/3053
描述你的变更
TaskWrapper.loop入口处立刻调用的extractSQL(),启动/重建只注册周期 tickerinterval==0告警返回与 tick 分支内采集;Manager / startAuditPlan 路径不变确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docMade with Cursor
Description
移除 TaskWrapper.loop 中 extractSQL() 的即时调用
延迟采集,等待周期性定时器启动
Diagram Walkthrough
File Walkthrough
task_wrap.go
删除即时采集调用sqle/server/auditplan/task_wrap.go