Skip to content

fix: remove MongoDB legacy advanced param ignore on connect - #3351

Closed
LordofAvernus wants to merge 2 commits into
mainfrom
dev-decathlon-mongo-odc-visibility
Closed

LordofAvernus wants to merge 2 commits into
mainfrom
dev-decathlon-mongo-odc-visibility

Conversation

@LordofAvernus

@LordofAvernus LordofAvernus commented Jul 28, 2026 •

Copy link
Copy Markdown
Collaborator

关联的 issue

https://github.com/actiontech/dms-ee/issues/941

描述你的变更

  • 移除 MongoDB 数据源高级选项(auth_mechanism / tls / tls_skip_verify / direct_connection),前后端与插件 meta/DSN 一并删除
  • 形态文案统一为「单机 / 副本集 / 分片集群」
  • 不再保留遗留四键的读取忽略 / 兼容 shim(开发期不引入向后兼容)
  • 补充/调整相关单测

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🎫 Ticket compliance analysis 🔶

941 - Partially compliant

Compliant requirements:

  • (无)

Non-compliant requirements:

  • 数据源框固定宽度需求在当前代码中没有体现

Requires further human verification:

  • (无)
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

代码优化

建议使用常量来代替硬编码的 "MongoDB" 字符串,从而提高代码的可维护性,并减少因手动输入错误可能导致的问题。此外,确保注释说明与实际逻辑保持一致以便后续维护。

// Ignore Mongo legacy advanced params removed from plugin meta (still present on old datasources).
if req.DBType == "MongoDB" {
	switch additionalParam.Name {
	case "auth_mechanism", "tls", "tls_skip_verify", "direct_connection":
		continue
	}
}

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
增加 default 分支

建议在针对 MongoDB 的额外参数判断中添加 default
分支,以确保其他未列举的参数能按照预期走后续逻辑。这样可以提升代码的健壮性,防止遗漏未来可能添加的特殊参数。

sqle/api/controller/v1/instance.go [269-275]

 // Ignore Mongo legacy advanced params removed from plugin meta (still present on old datasources).
 if req.DBType == "MongoDB" {
 	switch additionalParam.Name {
 	case "auth_mechanism", "tls", "tls_skip_verify", "direct_connection":
 		continue
+    default:
+        // 其他参数按照常规逻辑处理
 	}
 }
Suggestion importance[1-10]: 3

__

Why: The suggestion adds a default branch which is a minor stylistic change as Go's switch naturally falls through to subsequent logic if no case matches. This change doesn't affect functionality significantly.

Low

@LordofAvernus LordofAvernus changed the title fix: ignore MongoDB legacy advanced params on SQLE connect check fix: remove MongoDB legacy advanced param ignore on connect Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants