Skip to content

feat: 增加插件停止时的日志记录功能,便于调试和监控插件状态 - #3137

Merged
Jarvis1105 merged 1 commit into
mainfrom
fix/2541main
Sep 17, 2025
Merged

Jarvis1105 merged 1 commit into
mainfrom
fix/2541main

Conversation

@Seechi-Yolo

@Seechi-Yolo Seechi-Yolo commented Sep 17, 2025 •

Copy link
Copy Markdown
Collaborator

User description

关联的 issue

link https://github.com/actiontech/sqle-ee/pull/2542
https://github.com/actiontech/sqle-ee/issues/2541
方案和测试:https://github.com/actiontech/sqle-ee/issues/2541#issuecomment-3301777660

描述你的变更

  1. 增加插件主动关闭的日志,方便后续排查

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc


Description

  • 为插件停止操作增加日志记录

  • 更新插件管理器停止时记录日志


Diagram Walkthrough

flowchart LR
  A["调用 Stop 方法"] --> B["日志: 开始停止插件"]
  B --> C["调用 Kill 方法"]
  C --> D["日志: 插件停止完成"]
  A --> E["插件管理器记录停止日志"]
Loading

File Walkthrough

Relevant files
Enhancement
plugin_adapter_v2.go
插件停止时增加日志记录                                                                                           

sqle/driver/plugin_adapter_v2.go

  • 添加插件停止前日志记录:stopping plugin
  • 添加插件停止后日志记录:plugin stopped
+2/-0     
plugin_manager.go
插件管理器停止日志的记录                                                                                         

sqle/driver/plugin_manager.go

  • 插入插件管理器停止时的日志记录
  • 调用插件停止方法并处理异常日志
+1/-0     

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


linxiaotao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@actiontech-bot
actiontech-bot requested review from Jarvis1105 and removed request for Jarvis1105 September 17, 2025 08:30
@github-actions

Copy link
Copy Markdown

Failed to generate code suggestions for PR

@Jarvis1105
Jarvis1105 merged commit 7ce0163 into main Sep 17, 2025
3 of 4 checks passed
@Jarvis1105
Jarvis1105 deleted the fix/2541main branch September 17, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants