Add support to GitCmd - #916
Open
Aurze wants to merge 3 commits into
Open
Conversation
actionless
requested changes
Aug 4, 2026
Owner
|
(and idea itself is good) |
actionless
reviewed
Aug 4, 2026
actionless
reviewed
Aug 10, 2026
| ] | ||
| git_cmd = PikaurConfig().review.GitCmd.get_str() | ||
| git_args += shlex.split( | ||
| git_cmd.replace("{{repo_path}}", str(pkg_build.repo_path)) |
Owner
There was a problem hiding this comment.
this still looks a bit weird, i think it would make more sense to substitute items after the split
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
I wanna use difftastic to see PKGBUILD files diff
Solution
I allow to specify the git command to use
git -C {{repo_path}} diff --ignore-space-change --ignore-all-space {{last_install_hash}} {{current_hash}} -- .It allso has some "params" for variables.
Originally I implemented a "GitDiffExternalTool" but then I realize any new feature we would need yet an other params so instead I went with something more generic
Looking for feedback
So this solution works, I didn't test it like crazy yet, I'm looking on feedback like is this okay to let the user specify the full git command? This also deprecate the GitDiffArgs param, I could also put it as a replacable var? Or I can go back to a more specific approach of a GitDiffExternalTool.