Feat/project performance metrics - #1040
Open
alex-silverman wants to merge 34 commits into
Open
Conversation
…ce, as that is now more accurate. Client Counts is just a subtab.
Need to confirm some of the metrics' calculations with Victoria.
…of "ProjectPerformance".
…or Successful Exits)
- using latest enrollment (by EntryDate for all metrics except for Successful Exits and IncomeGrowth, where we use ExitDate) - fix naming of Entered into Non-Habitat metric - other minor typos - fix income growth calculation - add render functions for easier formatting - update UI for more consistent formatting and better handling of nulls/empties.
…ng up the metrics calculations into separate functions. Also starting the Detail calculations. Need to confirm how many of the metrics are to be calculated.
…ense to generate the metrics data first, then summarize and display as needed for Summary and Detail tabs
…ne out too early, since we're reporting folks as excluded.
…clear how the metrics are used and to reduce repetitive code
Merge branch 'dev' into feat/project_performance_metrics # Conflicts: # 04_initial_data_prep.R # demo_management.R # project_dashboard_server.R # server.R # tab_instructions.R # tests/testing_functions.R # tests/testthat/_snaps/linux-4.5/missing-export/test-missing-export-001.json # tests/testthat/_snaps/linux-4.5/missing-export/test-missing-export-002.json # tests/testthat/_snaps/linux-4.5/missing-export/test-missing-export-003.json # tests/testthat/_snaps/linux-4.5/missing-export/test-missing-export-004.json # tests/testthat/_snaps/linux-4.5/missing-export/test-missing-export-005.json # tests/testthat/_snaps/linux-4.5/missing-multiple-files/test-missing-multiple-files-001.json # tests/testthat/_snaps/linux-4.5/missing-multiple-files/test-missing-multiple-files-002.json # tests/testthat/_snaps/linux-4.5/missing-multiple-files/test-missing-multiple-files-003.json # tests/testthat/_snaps/linux-4.5/missing-multiple-files/test-missing-multiple-files-004.json # tests/testthat/_snaps/linux-4.5/missing-multiple-files/test-missing-multiple-files-005.json # tests/testthat/_snaps/linux-4.5/system-exits/system-exits-just-uploaded.json # tests/testthat/_snaps/linux-4.5/unhashed/test-unhashed-001.json # tests/testthat/_snaps/linux-4.5/unhashed/test-unhashed-002.json # tests/testthat/_snaps/linux-4.5/unhashed/test-unhashed-003.json # tests/testthat/_snaps/linux-4.5/unhashed/test-unhashed-004.json # tests/testthat/_snaps/linux-4.5/unhashed/test-unhashed-005.json # tests/testthat/_snaps/linux-4.5/wrong-csv-version/test-wrong-csv-version-001.json # tests/testthat/_snaps/linux-4.5/wrong-csv-version/test-wrong-csv-version-002.json # tests/testthat/_snaps/linux-4.5/wrong-csv-version/test-wrong-csv-version-003.json # tests/testthat/_snaps/linux-4.5/wrong-csv-version/test-wrong-csv-version-004.json # tests/testthat/_snaps/linux-4.5/wrong-csv-version/test-wrong-csv-version-005.json # tests/testthat/_snaps/linux-4.5/wrong-file-type/test-wrong-file-type-001.json # tests/testthat/_snaps/linux-4.5/wrong-file-type/test-wrong-file-type-002.json # tests/testthat/_snaps/linux-4.5/wrong-file-type/test-wrong-file-type-003.json # tests/testthat/_snaps/linux-4.5/wrong-file-type/test-wrong-file-type-004.json # tests/testthat/_snaps/linux-4.5/wrong-file-type/test-wrong-file-type-005.json # ui.R
mlfurman3
reviewed
Aug 11, 2026
Comment on lines
+690
to
+699
| selected_proj_type <- reactive({ | ||
| req(input$currentProviderList) | ||
| session$userData$Project0[ProjectName == input$currentProviderList, ProjectType][1] | ||
| }) | ||
|
|
||
|
|
||
| selected_proj_id <- reactive({ | ||
| req(input$currentProviderList) | ||
| session$userData$Project0[ProjectName == input$currentProviderList, ProjectID][1] | ||
| }) |
Collaborator
There was a problem hiding this comment.
This was originally accurate, but input$currentProviderList has since changed from being a ProjectName to a ProjectID (see recent timeliness PRs)
Collaborator
Author
There was a problem hiding this comment.
mlfurman3
reviewed
Aug 11, 2026
|
|
||
| income_growth_dt <- get_growth_dt(session$userData$IncomeBenefits, "TotalMonthlyIncome") | ||
|
|
||
| ce_assessments_dt <- ## Used only for CE Assessed Households Project Dashboard Metric ---- |
Collaborator
There was a problem hiding this comment.
It looks like this variable had an assignment that got dropped at some point- is it meant to be set to the same as session$userData$CEAssessedHouseholds below or just a merge issue?
Collaborator
Author
There was a problem hiding this comment.
Oops! I guess I had started something but hadn't finished. Fixed by 6e38ec5.
mlfurman3
requested changes
Aug 11, 2026
mlfurman3
left a comment
mlfurman3
left a comment
Collaborator
There was a problem hiding this comment.
Seeing some errors in project_dashboard_metrics_server.R for demo mode, so not able to view the new cards yet (even after changing the ProjectName to ProjectID)
…oject_dashboard_metrics_Server.R. Even though we only need session$userData$CEParticipation for just one purpose, it makes more sense to keep the metrics-related prep code in the apprpriate script. While this might mean the user waits a little longer for the metrics dashboard to load, users who don't go to the metrics tab don't have to wait.
…d household metric
…ciates/eva into feat/project_performance_metrics
Collaborator
Author
Sorry I sent this to you before it was ready. This was related to the ce_assessments_dt issue you noted above. I've fixed |
mlfurman3
reviewed
Aug 11, 2026
| div("Children: ", format_val(m$val[AgeGroup == "Child"]$n_unique, "clients")), | ||
| div("Unknown: ", format_val(m$val[AgeGroup == "Unknown"]$n_unique, "clients")) | ||
| ), | ||
| showcase = bs_icon("people"), |
Collaborator
There was a problem hiding this comment.
Could we update all icon colors to our typical dark blue?
Suggested change
| showcase = bs_icon("people"), | |
| showcase = bs_icon("people", color = get_brand_color('dark_blue')), |
mlfurman3
reviewed
Aug 11, 2026
mlfurman3
left a comment
mlfurman3
left a comment
Collaborator
There was a problem hiding this comment.
Almost there, I am able to see the metrics boxes now. But still getting an error in the Details subtab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/orgs/abtassociates/projects/1/views/1?pane=issue&itemId=114459791 for specs.