feat: V4 deployment scripts (review only) - #1326
Draft
avniculae wants to merge 6 commits into
Draft
Conversation
avniculae
force-pushed
the
feat/v4-deployments
branch
from
July 28, 2026 09:15
1ee6cda to
c20a0a6
Compare
The Paxos Hub was renamed to Global Dollar Hub, so the replacement TokenizationSpokes take the Global Dollar naming: shareName `Wrapped Aave Global Dollar <asset>` and shareSymbol `waGlobalDollar<asset>`. Both feed the CREATE2 address (the symbol is the salt label and both go into the proxy init data), so the three instances already deployed on mainnet (0xFaB4..d2fD, 0xF38C..0E27, 0xB408..E406) are obsolete and need a redeploy. The activation batch has not been executed on mainnet, so nothing is live. The `NEW_WA_GLOBAL_DOLLAR_*` addresses in the activation fork test are the deterministic addresses for deployer 0x0315d353045f8FBCDd8CAcEbA40b019d094B670E; the same derivation reproduces the three currently deployed addresses exactly. A new devnet is required for that test to pass again.
avniculae
force-pushed
the
feat/v4-deployments
branch
from
July 28, 2026 09:15
c20a0a6 to
6586a87
Compare
Kogaroshi
reviewed
Jul 28, 2026
Comment on lines
+95
to
+98
| address public constant ACCESS_MANAGER = 0x08aE3BE30958cDd1847ec58fFfd4C451a87fDF01; | ||
| // GovernanceV3Ethereum.EXECUTOR_LVL_1 | ||
| // https://github.com/aave-dao/aave-address-book/blob/c48a741a10b94202f738d52a09e9c9a8bf18a67d/src/GovernanceV3Ethereum.sol#L56 | ||
| address public constant EXECUTOR_LVL_1 = 0x5300A1a15135EA4dc7aD5a167152C01EFc9b192A; |
Contributor
There was a problem hiding this comment.
I really don't want to import the aave-address-book here (since the address book import v4 as well), but I'm not a fan either of copy-pasting the addresses like this as well.
How about we do like with Gho, and start an aave-v4-deploy repo that imports aave-v4 & the address-book, and where those scripts + related tests can live ?
Member
There was a problem hiding this comment.
I like Standalone more than Isolated. Also, do we need to add this distinction?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review only, not for merge.
Scripts:
scripts/deploy/AaveV4DeployCorrelatedSpoke.s.sol— base plusAaveV4DeployUSDGCorrelatedSpokeandAaveV4DeployMapleCorrelatedSpokescripts/deploy/AaveV4DeployIsolatedHub.s.sol— base plusAaveV4DeployPendlePaxosIsolatedHubscripts/deploy/AaveV4DeployTokenizationSpoke.s.sol— base plusAaveV4DeployGlobalDollarTokenizationSpokesTests:
tests/scripts/AaveV4DeployUSDGCorrelatedSpoke.t.soltests/scripts/AaveV4DeployMapleCorrelatedSpoke.t.soltests/scripts/AaveV4DeployGlobalDollarTokenizationSpokes.t.soltests/deployments/fork/GlobalDollarTokenizationSpokesActivation.t.sol— devnet activation test, self-skips withoutTENDERLY_DEVNET_RPC