-
Notifications
You must be signed in to change notification settings - Fork 112
feat: certora cvl v0.5.11 #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yan-man
wants to merge
22
commits into
main
Choose a base branch
from
feat/certora-cvl-v0.5.11
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1feea7c
Feat/certora cvl (#1288)
nd-certora 91d00ed
Merge branch 'main' into feat/certora-cvl-v0.5.11
yan-man a57acf9
ci: rm flaky spec; workflow to hide certora comment
yan-man 044f695
fix: comment out flaky specs
yan-man 560e6ba
ci: minimize comment classifier
yan-man 48aa927
docs: accounting invariant; update readme
yan-man 2fd1b90
fix: restore prev failing specs
yan-man 1f74ad3
chore: rm CI workflow
yan-man c6bb8c1
fix: import
yan-man 51f04e5
Feat/certora cvl v0.5.11 (#1296)
nd-certora dcd67ad
Feat/certora cvl v0.5.11 (#1298)
nd-certora 712c003
fix: rm unneeded harness; CI comment always
yan-man adba16f
CI: flaky specs
yan-man 5876799
fix: clarify invariant
yan-man e2cc029
fix: rm spoke harness from readme
yan-man 52b2431
chore: revert changes; port to docs pr
yan-man 87e03ba
Merge branch 'main' into feat/certora-cvl-v0.5.11
yan-man 7c3067f
fix: rm flaky spec
yan-man 5805427
feat: links
yan-man 009859c
feat: include public URL links
yan-man c8498f6
feat: comments on rules
yan-man a4cd8f6
feat: links to runs
yan-man File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| name: Certora Prover Fast Rules only | ||
|
|
||
| env: | ||
| CONFIGS: | | ||
| certora/conf/libs/LibBit.conf | ||
| certora/conf/libs/LiquidationLogic_Bonus.conf | ||
| certora/conf/libs/LiquidationLogic_debtToLiquidate.conf | ||
| certora/conf/libs/LiquidationLogic.conf --exclude_rule collateralToLiquidateValueLessThanDebtToLiquidate collateralToLiquidateValueLessThanDebtToLiquidate_general | ||
| certora/conf/libs/Math.conf | ||
| certora/conf/libs/Premium.conf | ||
| certora/conf/libs/SharesMath.conf | ||
| certora/conf/libs/SpokeUtils_toValue.conf | ||
| certora/conf/Hub.conf --exclude_rule noChangeToOtherSpoke supplyExchangeRateIsMonotonic supplyExchangeRateIsMonotonic_eliminateDeficit_simplified totalAssetsCompareToSuppliedAmount_noVirtual | ||
| certora/conf/Hub.conf --rule noChangeToOtherSpoke | ||
| certora/conf/HubAccrueIntegrity.conf | ||
| certora/conf/HubAccrueUnrealizedFee.conf | ||
| certora/conf/HubAccrueSupplyRate.conf --exclude_rule previewRemoveByShares_withoutAccrue_time_monotonic previewRemoveByAssets_withoutAccrue_time_monotonic | ||
| certora/conf/HubIntegrity.conf | ||
| certora/conf/HubValidState.conf --exclude_rule totalAssetsVsShares_eliminateDeficit totalAssetsVsShares | ||
| certora/conf/LiquidationIntegrity.conf | ||
| certora/conf/LiquidationUserIntegrity.conf | ||
| certora/conf/Spoke.conf --rule drawnSharesZero | ||
| certora/conf/Spoke.conf --exclude_rule drawnSharesZero noCollateralNoDebt increaseCollateralOrReduceDebtFunctions | ||
| certora/conf/Spoke.conf --rule increaseCollateralOrReduceDebtFunctions | ||
| certora/conf/SpokeHealthCheck.conf | ||
| certora/conf/SpokeHealthFactor.conf --exclude_rule userHealthAboveThreshold userHealthBelowThresholdCanOnlyIncreaseHealthFactor | ||
| certora/conf/SpokeIntegrity.conf | ||
| certora/conf/SpokeUserIntegrity.conf | ||
| certora/conf/SpokeWithHub.conf --rule userDrawnShareConsistency | ||
| certora/conf/SpokeWithHub.conf --rule userPremiumShareConsistency | ||
| certora/conf/SpokeWithHub.conf --rule userPremiumOffsetConsistency | ||
| certora/conf/SpokeWithHub.conf --rule userSuppliedShareConsistency | ||
| certora/conf/SpokeWithHub.conf --exclude_rule userDrawnShareConsistency userPremiumShareConsistency userPremiumOffsetConsistency userSuppliedShareConsistency | ||
| ######### ######### | ||
| ######### rules that are too long/flaky to run in ci, run manually ######### | ||
| ######### ######### | ||
| # certora/conf/HubValidState_totalAssets.conf | ||
| # certora/conf/Spoke_noCollateralNoDebt.conf | ||
| # certora/conf/Hub.conf --rule supplyExchangeRateIsMonotonic | ||
| # certora/conf/Hub.conf --rule supplyExchangeRateIsMonotonic_eliminateDeficit_simplified | ||
| # certora/conf/Hub.conf --rule totalAssetsCompareToSuppliedAmount_noVirtual | ||
| # certora/conf/HubAdditivity.conf --rule drawAdditivity | ||
| # certora/conf/HubAdditivity.conf --rule restoreAdditivity | ||
| # certora/conf/HubAdditivity.conf --rule reportDeficitAdditivity | ||
| # certora/conf/HubAdditivity.conf --exclude_rule drawAdditivity restoreAdditivity reportDeficitAdditivity | ||
| # certora/conf/SpokeHealthFactor.conf --rule userHealthAboveThreshold | ||
| # certora/conf/SpokeHealthFactor.conf --rule userHealthBelowThresholdCanOnlyIncreaseHealthFactor | ||
| # certora/conf/HubAccrueSupplyRate.conf --rule previewRemoveByShares_withoutAccrue_time_monotonic previewRemoveByAssets_withoutAccrue_time_monotonic | ||
| # certora/conf/libs/LiquidationLogic.conf --rule collateralToLiquidateValueLessThanDebtToLiquidate | ||
| # certora/conf/HubValidState.conf --rule totalAssetsVsShares_eliminateDeficit | ||
| # certora/conf/LiquidationReportDeficit.conf | ||
| # certora/conf/Liquidation.conf | ||
| # certora/conf/libs/PositionStatus.conf | ||
| # certora/conf/libs/VerifySymbolicPositionStatus.conf | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - certora | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| verify: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| statuses: write | ||
| pull-requests: write | ||
| id-token: write | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
|
|
||
| # (Optional) Add installation steps for your project | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| - name: Install dependencies | ||
| run: npm install | ||
|
|
||
| # Run Certora Prover | ||
| - uses: Certora/certora-run-action@v2 | ||
| with: | ||
| # Add your configurations as lines, each line is separated. | ||
| # Specify additional options for each configuration by adding them after the configuration. | ||
| configurations: ${{ env.CONFIGS }} | ||
| solc-versions: 0.8.28 | ||
| job-name: "Verified Rules" | ||
| certora-key: ${{ secrets.CERTORAKEY }} | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
yan-man marked this conversation as resolved.
Outdated
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: Minimize Certora Comments | ||
|
|
||
| on: | ||
| pull_request_review: | ||
| types: [submitted, edited] | ||
|
|
||
| permissions: | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| minimize: | ||
| runs-on: ubuntu-latest | ||
| if: >- | ||
| github.event.review.user.login == 'certora-run[bot]' || | ||
| (github.event.review.user.type == 'Bot' && contains(github.event.review.body, 'Verified Rules')) | ||
| steps: | ||
| - uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| try { | ||
| await github.graphql(` | ||
| mutation($id: ID!) { | ||
| minimizeComment(input: {subjectId: $id, classifier: RESOLVED}) { | ||
| minimizedComment { isMinimized } | ||
| } | ||
| } | ||
| `, { id: context.payload.review.node_id }); | ||
| console.log('Minimized certora review comment'); | ||
| } catch (e) { | ||
| console.log(`Failed to minimize comment: ${e.message}`); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,4 @@ report/ | |
|
|
||
| .DS_Store | ||
| .venv/ | ||
| .certora_internal/ | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: Liquidation spec is flaky and commented out here (but succeeds on local run)