WIP: add trimming support - #917
Draft
zivillian wants to merge 10 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started to prepare the library for trmming according to documentation.
My goal was to be able to publish my project (which uses YamlDotNet) trimmed without getting a warning. I know, that there was some previous work in #740 and #758, but even though I used a static context it still produced warnings because YamlDotNet is not marked as trimmable.
Now I'm a bit stuck, because the docs recommend to
But there are still ~60 warnings, but all remaining methods are either overrides or interface implementations.
Since I've spent a few hours, I didn't want to just throw it away and instead created this draft. Maybe someone has an idea how to continue.
I've deleted some methods and files, because they were unused, internal and produced additional trim warnings - so deleting was easier than annotating them.