Skip to content

Adding async methods to serialization API #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DanielBeckwith wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Adding async methods to serialization API #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9def345
Add the surface-level async methods
DanielBeckwith Feb 20, 2024
47e8367
Update emitter to use generators instead of direct writes
DanielBeckwith Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions YamlDotNet.Test/RepresentationModel/YamlStreamTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
using System.IO;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using FluentAssertions;
using Xunit;
using YamlDotNet.Core;
Expand Down Expand Up @@ -402,6 +403,19 @@ public void Emit(ParsingEvent @event)

Assert.False(scalar.IsQuotedImplicit);
}

public Task EmitAsync(ParsingEvent @event)

@zivillian zivillian Mar 26, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to have a CancellationToken parameter in all async mathods

{
try
{
Emit(@event);
return Task.CompletedTask;
}
catch (Exception ex)
{
return Task.FromException(ex);
}
}
}
}
}
Loading