Optimize allocations in next_siblings - #66
Open
tysg wants to merge 1 commit into
Open
Conversation
used by next_element on readability hot path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes allocations for
Soup.next_siblingsat the cost of code elegance :) Similar to #64 , we found this function when profiling allocations in our internal code.Our code heavily uses
Soup.next_elementwhich builds the prefix list then discards it. So it's kinda of a waste.This PR replaces
split_at_identitywith specializedsuffix_after_identifyandprefix_before_identity, so that insuffix_after_identityno new list is allocated.Obviously this looks like an edge for day-to-day use. So please feel free to close this PR if the tradeoff doesn't make sense.