Repository navigation
fix(writing): close agent-instructions eval leftovers - #54
Merged
Merged
Conversation
… in the Skill Refs: #17
…eval matrix - review.md: make the round copy in its own tool call, and put no other tool call in the message that saves a report. - SKILL.md: add the entry-format vs "do not omit words" case to the conflict table. - agent-skills-spec.md: a description that gives an instruction is procedural text (20-word limit). - evals.json: give test 5 an action for the Guidance line, and make [5.1] name the 3 lines it checks. Refs: #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the #17 eval leftovers for the agent-instructions Skill. The rules stay in the Skill files, and
grader.mdpoints to them.ste-rules.md: word-count rules (colons, multi-word nouns, headings, code blocks) and a table of count examples.review.md: numbered counts near the limit, a file copy anddiffto find the changed sections, no change to a saved report, and one report per message (no copy orgitcall in it).SKILL.md: a finding comes only from a reviewer report; a new conflict-table row for the glossary/MEMORY.mdentry format.agent-skills-spec.md: a description that gives an instruction is procedural text.plain-language-checks.md,technical-terms.md: glossary words in lowercase; when a colon stops a sentence.countWordsineval-lib.ts, tested against the examples inste-rules.md.grader.mdpoints to the Skill sections. Test 5 gives an action for the Guidance line, and [5.1] names the 3 lines.Evidence
208615c): 112/115. Failures: test 4 [4.1], test 5 [5.1], test 10 [10.2].After (matrix-3,
1d123ee): 115/115. Claude Code 2.1.302, one run per test, one fresh grader per test.docker compose run --rm bun run checkexits 0. A changed example inste-rules.mdmakes thecountWordstest fail.Merge Danger
Door: two-way
Blast Radius: skill-users
Projects that install the agent-instructions Skill get the new rules once they reach
main.Refs: #17