More-better shunt guidance - #522
Merged
Merged
Conversation
Inspired by Léo's suggestion to the last PR in this file.
It's not needed. Shunt filters will always get a value. In this specific case, removing yourls_shunt_default() preserves back-compat.
ozh
approved these changes
Aug 19, 2026
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
website | b5c67f7 | Commit Preview URL Branch Preview URL |
Aug 19 2026, 06:09 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-requisites
Change Description
Follow-up to #521 regarding the example shunt filter, specifically, implementing @ozh's suggestion for better backward compatibility (avoiding use of the new-in-1.10.4 function
yourls_shunt_default()) and my own alternative idea for a different parameter name.What do @YOURLS/core think? Do you like this or would
$dont_shuntbe better after all?