Repository navigation
Conversation
Co-authored-by: Xp-boss <67393766+Xp-boss@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
📊 PR Size: size/M
|
|
Closing this fork PR: it now conflicts with PR #1, which was merged into this fork's main today — both change the same file, packages/core/src/utils/agent-sanitization-utils.ts, in the same area. This PR's work is not lost: it is already submitted upstream as google-gemini/gemini-cli PR google-gemini#30349, which is clean and mergeable. The branch is being kept completely untouched so the upstream PR stays intact. This fork PR can be reopened if ever needed. |
KEY_WITH_DELIMITER_REGEX,SPACE_SEPARATED_REGEX,FILE_PATH_REDACT_REGEX) and pre-computed normalized sensitive key patterns (NORMALIZED_SENSITIVE_PATTERNS) at module scope inpackages/core/src/utils/agent-sanitization-utils.ts.sanitizeErrorMessagere-compiled multiple regular expressions vianew RegExp(...)on every call, andsanitizeToolArgsre-normalizedSENSITIVE_KEY_PATTERNSfor every property key of every object passed to it, causing significant CPU and GC overhead on the hot path for tool call execution and error handling.sanitizeToolArgsandsanitizeErrorMessagewith nested objects and sensitive parameters.PR created automatically by Jules for task 1806637096253111347 started by @Xp-boss