Skip to content

fix typo foudationWalletAddr for testnet #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gzliudan wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −2
Open

fix typo foudationWalletAddr for testnet #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions testnet/genesis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"reward": 5000,
"rewardCheckpoint": 900,
"gap": 450,
"foudationWalletAddr": "xdc746249c61f5832c5eed53172776b460491bdcd5c"
"foundationWalletAddr": "xdc746249c61f5832c5eed53172776b460491bdcd5c"

@coderabbitai coderabbitai Bot Feb 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for references to both field name variants and related code

echo "=== Searching for 'foundationWalletAddr' (correct spelling) ==="
rg -n 'foundationWalletAddr' --max-count=20

echo ""
echo "=== Searching for 'foudationWalletAddr' (misspelled version) ==="
rg -n 'foudationWalletAddr' --max-count=20

echo ""
echo "=== Searching for 'foundation' in genesis-related code ==="
rg -n 'foundation' -i --type go --type json -B2 -A2 | head -50

echo ""
echo "=== Finding all genesis JSON files ==="
find . -name 'genesis.json' -type f 2>/dev/null

Repository: XinFinOrg/XinFin-Node

Length of output: 914

🏁 Script executed:

#!/bin/bash
# Search for Go struct definitions that map genesis JSON fields

echo "=== Searching for Genesis struct definitions ==="
rg -n 'type.*Genesis' --type go -A 30 | head -100

echo ""
echo "=== Searching for JSON struct tags related to genesis ==="
rg -n 'json:".*Wallet' --type go -B2 -A2

echo ""
echo "=== Searching for any code that reads/parses genesis files ==="
rg -n 'genesis\.json' --type go -B2 -A2

echo ""
echo "=== Check Go files in root and common directories ==="
find . -maxdepth 3 -name '*.go' -type f | head -20

Repository: XinFinOrg/XinFin-Node

Length of output: 755

🏁 Script executed:

#!/bin/bash
# Understand repository structure

echo "=== Repository structure ==="
ls -la | head -20

echo ""
echo "=== File types in repository ==="
find . -type f -name '*.go' -o -name '*.js' -o -name '*.sol' -o -name '*.py' -o -name '*.java' 2>/dev/null | head -20

echo ""
echo "=== Check if there are any subdirectories that might contain code ==="
ls -d */ 2>/dev/null | head -20

echo ""
echo "=== Total files in repository ==="
git ls-files | wc -l

echo ""
echo "=== List all files to understand the repo ==="
git ls-files | head -50

Repository: XinFinOrg/XinFin-Node

Length of output: 2334

🏁 Script executed:

#!/bin/bash
# Check if the address creator code references foundationWalletAddr or genesis fields

echo "=== Checking address-creator.js for references ==="
cat -n address-creator/address-creator.js | grep -i 'foundation\|wallet\|genesis' || echo "No matches found"

echo ""
echo "=== Full address-creator.js content ==="
cat -n address-creator/address-creator.js

Repository: XinFinOrg/XinFin-Node

Length of output: 1636

Fix the typo in devnet and mainnet genesis files as well.

The spelling correction is correct, but the fix is incomplete. The misspelled field foudationWalletAddr remains in both devnet/genesis.json:16 and mainnet/genesis.json:16. Apply the same correction to all three genesis files for consistency:

  • testnet/genesis.json:16 ✓ (corrected)
  • devnet/genesis.json:16 (needs fix: foudationWalletAddr → foundationWalletAddr)
  • mainnet/genesis.json:16 (needs fix: foudationWalletAddr → foundationWalletAddr)
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@testnet/genesis.json` at line 16, The devnet and mainnet genesis JSON files
still use the misspelled key "foudationWalletAddr"; update those files so the
key is spelled "foundationWalletAddr" (exactly matching the corrected key in
testnet) while keeping the associated wallet address value unchanged, and search
the repository for any other occurrences of "foudationWalletAddr" to replace
with "foundationWalletAddr" to ensure consistency.

}
},
"nonce": "0x0",
Expand Down Expand Up @@ -133,7 +133,6 @@
"03c0d9bc556BE68870B96976e81D32ebb49d335D": {
"balance": "0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF"
}

},
"number": "0x0",
"gasUsed": "0x0",
Expand Down