Repository navigation
fix: correct CTID Network ID character range in quickstart - #667
Open
praveenpretto-cloud wants to merge 1 commit into
Open
praveenpretto-cloud wants to merge 1 commit into
praveenpretto-cloud wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The corrected range accurately identifies the four-character field, with no unresolved issues.
No open issues 🎉
What changed in this PR
Corrects the CTID quickstart’s Network ID character range to match the 16-character identifier format.
Changes:
- Changes the range from
12-16to12-15; no code or protocol behavior changes.
| File | Description |
|---|---|
| XLS-0037-concise-transaction-identifier-ctid/QUICKSTART.md | Corrects the Network ID’s final character index. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Correct the Network ID character offset from
12-16to12-15inXLS-0037-concise-transaction-identifier-ctid/QUICKSTART.md.Context of Change
CTIDs contain 16 hexadecimal characters with zero-based indices
0through15. The four-character Network ID field occupies indices12-15, so thequickstart's
12-16range is incorrect.This correction matches the format table in the CTID README.
This is a documentation-only change; no code or protocol behavior changes.
Type of Change
Verification
Confirmed the format
CXXXXXXXYYYYZZZZcontains 16 characters.Compared the Network ID range with the CTID README, which says
12-15.Ran
node ctid.jslocally and received: