Skip to content

(release/25.1) Fix DPI property not reporting accurate value when autosetDPI is TRUE - #3668

Open
metux wants to merge 2 commits into
release/25.1from
pr/release/25.1-fix-dpi-property-not-reporting-accurate-value-when-autosetdpi-is-true_2026-08-31_15-09-40
Open

metux wants to merge 2 commits into
release/25.1from
pr/release/25.1-fix-dpi-property-not-reporting-accurate-value-when-autosetdpi-is-true_2026-08-31_15-09-40

Conversation

@metux

@metux metux commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Fix DPI property not reporting accurate value when autosetDPI is TRUE

This fix corrects the DPI value calculation to use autosetDPI when monitorResolution
is not set.

Backport of #3628 (merge commit 7cc65bb)

(cherry picked from commit 7cc65bb)

@metux metux self-assigned this Aug 31, 2026
@metux
metux requested a review from a team August 31, 2026 13:11
@metux

metux commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Automated review — generated by Starfleet ship Voyager on behalf of @metux. Not a human review.

Reviewed randr/rroutput.c — the release backport of #3628.

Verdict: PASS

The cherry-pick of merge commit 7cc65bb applied cleanly to 25.1 and 25.2, bringing
both the DPI auto-detection feature (commit e950e1f) and the bugfix (commit 14205d7).
The fix adds the autosetDPI branch to the DPI value calculation, using screen dimensions
when no explicit resolution is set.

No ABI impact (internal DPI property logic). The feature adds new global autosetDPI
and -dpi auto CLI handling (in other files), which were also included in the cherry-pick.

25.0 skipped: predates the DPI feature entirely; the bugfix doesn't apply standalone.

No blocking findings.

@metux metux added the bot-review-passed Automated bot review found no blocking issues label Aug 31, 2026
@kaolinite7

Copy link
Copy Markdown
Contributor

Add commit e950e1f058 to this PR.

This PR re-adds support for DPI Auto-Detection which was available in X.Org till 21.1, but was removed. This reverts commit 35af129 and allows to get Auto DPI Detection back only when specified by user as:
$ X -dpi auto

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
(cherry picked from commit 7cc65bb)
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
@metux
metux force-pushed the pr/release/25.1-fix-dpi-property-not-reporting-accurate-value-when-autosetdpi-is-true_2026-08-31_15-09-40 branch from 965d7d2 to 6ec23dd Compare September 14, 2026 13:54
@metux

metux commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Add commit e950e1f058 to this PR.

thanks.

big question now is: shall we really add it to existing release - does it qualify as a bugfix ?

@metux
metux force-pushed the pr/release/25.1-fix-dpi-property-not-reporting-accurate-value-when-autosetdpi-is-true_2026-08-31_15-09-40 branch from 6ec23dd to 115ee51 Compare September 14, 2026 13:55
@kaolinite7

Copy link
Copy Markdown
Contributor

Add commit e950e1f058 to this PR.

thanks.

big question now is: shall we really add it to existing release - does it qualify as a bugfix ?

@metux I think this should be added into the newer version, it works fine with 25.1.9. Shouldn't be labeled as a Bugfix in my opinion, rather it should be added as a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-passed Automated bot review found no blocking issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants