Skip to content

Fix UnicodeDecodeError when parsing WordPress titles containing emoji #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ak5869 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Open

Fix UnicodeDecodeError when parsing WordPress titles containing emoji #5589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions catalog/dags/providers/provider_api_scripts/wordpress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"""

import logging

import re
import lxml.html as html

from common import constants
Expand Down Expand Up @@ -172,9 +172,12 @@ def _get_title(image):
if title := image.get("content", {}).get("rendered"):
try:
title = html.fromstring(title).text_content()
except UnicodeDecodeError as e:
logger.warning(f"Can't save the image's title ('{title}') due to {e}")
return None
except UnicodeDecodeError:
# lxml's HTML parser can raise UnicodeDecodeError on titles
# containing certain emoji. Fall back to a regex-based tag
# strip, which operates on the original str and never
# re-encodes it, so emoji are preserved correctly.
title = re.sub(r"<[^<]+?>", "", title).strip()
return title

@staticmethod
Expand Down
5 changes: 5 additions & 0 deletions catalog/tests/dags/providers/provider_api_scripts/test_wordpress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ def test_get_title(ingester):
expected_result = "Coffee Bean with bags"
assert actual_result == expected_result

def test_get_title_handles_emoji(ingester):
image_data = {"content": {"rendered": "<p>Tomato Basil \U0001F33F Soup</p>\n"}}
actual_result = ingester._get_title(image_data)
expected_result = "Tomato Basil \U0001F33F Soup"
assert actual_result == expected_result

def test_get_file_info(ingester):
image_details = (
Expand Down
Loading