Explain test runner SSH configuration - #402
Open
yusufhay wants to merge 1 commit into
Open
Conversation
|
Nice, clear addition. The distinction between leaving WPT_SSH_CONNECT empty for same server runs versus using it for a remote target is well explained, and the security guidance (dedicated test account and database, protecting the .env holding WPT_SSH_PRIVATE_KEY_BASE64, and not targeting production) is exactly right for this context. It reads consistently with the surrounding tests.md section. LGTM from a docs perspective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WPT_SSH_CONNECTempty.Closes #65.
Testing
tests.mdand adds one focused section after the environment variable example.