Skip to content

Widget Dashboard: Use UI Spinner and remove Components dependency - #82837

Open
ciampo wants to merge 9 commits into
codex/widget-dashboard-ui-menufrom
codex/widget-dashboard-ui-spinner
Open

ciampo wants to merge 9 commits into
codex/widget-dashboard-ui-menufrom
codex/widget-dashboard-ui-spinner

Conversation

@ciampo

@ciampo ciampo commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Stacked on #81929.

What?

Use @wordpress/ui Spinner in the widget dashboard.

Why?

Remove the package's direct dependency on @wordpress/components.

How?

Migrate the remaining story Buttons, remove the dependency and TypeScript references, and load transitive Components styles through Storybook's shared setup.

Testing Instructions

Enable New Dashboard experience in Gutenberg experiments. Open Dashboard (Beta) with network throttling and confirm that each loading spinner is centered and disappears when its widget loads.

Testing Instructions for Keyboard

In Storybook's Widget Dashboard → Playground → Debug → Staging Enforcement, Tab to a debug button and activate it with Enter or Space.

Screenshots

Screenshot 2026-09-14 at 13 34 32 Screenshot 2026-09-14 at 13 36 35

Use of AI Tools

Codex implemented the change, ran checks, and performed an independent adversarial review.

@ciampo ciampo added the [Type] Enhancement A suggestion for improvement. label Sep 14, 2026
@github-actions github-actions Bot added the [Package] Widget Dashboard /packages/widget-dashboard label Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

🤖 PR meta 🤖

📦 Bundle size

Size Change: 0 B

Total Size: 8.08 MB

b75c0a6 Run

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric c459b85 codex/widget-dashboard-ui-menu % Change
timeToFirstByte 56.35 ms +14.37% -3.37% 55.25 ms +10.41% -3.98% 1.99%
largestContentfulPaint 92 ms +8.7% -4.35% 92 ms +6.52% -4.35% 0%
lcpMinusTtfb 34.05 ms +14.83% -3.52% 34.35 ms +3.49% -6.7% -0.87%
wpBeforeTemplate 27.88 ms +10.87% -1.87% 27.45 ms +11.58% -2.62% 1.57%
wpTemplate 24.09 ms +2.37% -2.66% 23.71 ms +3.71% -3.58% 1.6%
wpTotal 52.62 ms +13.87% -2.87% 51.79 ms +9.46% -4.34% 1.6%
wpMemoryUsage 7.53 MB +0% -0% 7.52 MB +0% -0% 0.09%
wpDbQueries 17 +0% -0% 17 +0% -0% 0%

front-end-classic-theme

Metric c459b85 codex/widget-dashboard-ui-menu % Change
timeToFirstByte 46.35 ms +4.85% -1.73% 46.15 ms +5.74% -1.95% 0.43%
largestContentfulPaint 100 ms +4% -0% 100 ms +0% -0% 0%
lcpMinusTtfb 53.9 ms +1.95% -0.74% 54.25 ms +1.57% -2.67% -0.65%
wpBeforeTemplate 25.66 ms +4.99% -2.1% 25.08 ms +8.21% -1.83% 2.31%
wpTemplate 17.49 ms +2.17% -0.8% 17.47 ms +4.18% -1.14% 0.11%
wpTotal 43.42 ms +4.68% -1.96% 42.91 ms +6.64% -1.26% 1.19%
wpMemoryUsage 6.15 MB +0% -0% 6.14 MB +0% -0% 0.11%
wpDbQueries 14 +0% -0% 14 +0% -0% 0%

media-processing

Metric c459b85 codex/widget-dashboard-ui-menu % Change
mediaProcessingJpeg 393.99 ms +2.69% -0.61% 396.7 ms +1.07% -0.71% -0.68%
mediaProcessingAvif 6040.02 ms +0.16% -0.25% 6005.1 ms +0.16% -0.18% 0.58%
mediaProcessingJpegToAvif 4191.92 ms +0.22% -0.36% 4143.47 ms +0.13% -0.07% 1.17%

media-upload

Metric c459b85 codex/widget-dashboard-ui-menu % Change
jpegUploadProcessing 1449.3 ms +33.67% -3.26% 1416.51 ms +1.33% -0.24% 2.31%
pngUploadProcessing 211.61 ms +2.86% -6.07% 216.43 ms +4.56% -0.71% -2.23%
largeJpegUploadProcessing 1408.44 ms +1.37% -0.45% 1411.59 ms +1.07% -0.21% -0.22%
multipleImageUploadProcessing 1552.95 ms +0.65% -2.97% 1586.83 ms +7.69% -0.86% -2.14%

post-editor

Metric c459b85 codex/widget-dashboard-ui-menu % Change
serverResponse 533.62 ms +2.34% -5.93% 529.74 ms +3.75% -6.12% 0.73%
firstPaint 240.12 ms +10.72% -8.92% 260.48 ms +74.48% -22.43% -7.82%
domContentLoaded 1086.2 ms +1.31% -1.87% 1096.72 ms +1.72% -2.62% -0.96%
loaded 1087.54 ms +1.33% -1.86% 1098.14 ms +1.73% -2.63% -0.97%
firstContentfulPaint 447.88 ms +1.5% -3.6% 454.34 ms +2.08% -3.85% -1.42%
firstBlock 3359.29 ms +0.47% -2.07% 3442.72 ms +0.63% -1.88% -2.42%
type 16.21 ms +7.16% -5.74% 17.23 ms +1.51% -4.06% -5.92%
typeWithoutInspector 14.85 ms +10.64% -7.07% 14.85 ms +13.33% -1.55% 0%
typeWithTopToolbar 19.27 ms +25.17% -6.02% 20.39 ms +1.23% -3.87% -5.49%
typeContainer 9.7 ms +6.19% -4.23% 9.92 ms +13.91% -16.03% -2.22%
focus 77.79 ms +4.79% -7.25% 80.37 ms +11.8% -2.39% -3.21%
firstFocus 168.47 ms +0% -0% 184.67 ms +0% -0% -8.77%
selectAll 593.04 ms +2.9% -0.76% 632.04 ms +0.54% -1.3% -6.17%
listViewOpen 69.16 ms +15.4% -2.08% 77.43 ms +7.44% -6.06% -10.68%
inserterOpen 23.28 ms +9.11% -5.84% 23.86 ms +3.56% -11.53% -2.43%
inserterHover 3.85 ms +13.51% -5.97% 3.55 ms +4.23% -7.61% 8.45%
inserterSearch 7.89 ms +9.13% -5.2% 8.73 ms +16.61% -5.73% -9.62%
loadPatterns 662.9 ms +4.25% -0.87% 658.01 ms +4.4% -4.97% 0.74%
wpTotal 522.6 ms +2.55% -5.86% 519.74 ms +3.77% -6.28% 0.55%
wpMemoryUsage 13.06 MB +0% -0% 13.05 MB +0% -0% 0.08%
wpDbQueries 54 +0% -1.85% 54 +0% -0% 0%

site-editor

Metric c459b85 codex/widget-dashboard-ui-menu % Change
serverResponse 296.75 ms +6.1% -5.38% 309.9 ms +2.07% -6.03% -4.24%
firstPaint 170.46 ms +17.38% -10.4% 194.02 ms +5.14% -15.2% -12.14%
domContentLoaded 858.86 ms +1.02% -3.48% 867.08 ms +0.72% -0.89% -0.95%
loaded 859.89 ms +1.02% -3.48% 868 ms +0.71% -0.87% -0.93%
firstContentfulPaint 345.08 ms +4.08% -3.53% 346.1 ms +1.85% -2.3% -0.29%
firstBlock 3098.28 ms +2.03% -1.53% 3128.21 ms +0.94% -0.78% -0.96%
type 13.32 ms +4.5% -4.88% 13.9 ms +6.76% -4.96% -4.17%
navigate 105.25 ms +1.22% -8.49% 109.84 ms +10.26% -9.91% -4.18%
loadPatterns 1006.21 ms +4.44% -6.84% 1112.36 ms +9.42% -4.97% -9.54%
loadPages 1082.17 ms +0.76% -1.04% 1071.56 ms +1.58% -2.73% 0.99%
wpTotal 288.47 ms +6.27% -5.6% 301.42 ms +2.13% -6.18% -4.3%
wpMemoryUsage 12.02 MB +0% -0% 12.01 MB +0% -0% 0.05%
wpDbQueries 44 +0% -2.27% 44 +0% -2.27% 0%

b75c0a6 Run

@ciampo ciampo self-assigned this Sep 14, 2026
@ciampo
ciampo marked this pull request as ready for review September 14, 2026 11:37
@ciampo
ciampo requested a review from retrofox as a code owner September 14, 2026 11:37
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ciampo <mciampini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ciampo
ciampo force-pushed the codex/widget-dashboard-ui-menu branch from ab78639 to 8e04334 Compare September 14, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Widget Dashboard /packages/widget-dashboard [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant