Repair wp/7.0 branch Actions: remove SimenB/github-actions-cpu-cores dependency - #82804
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
All affected jobs use Ubuntu runners where nproc is available, preserving existing worker-count behavior.
Pull request overview
Removes an unnecessary third-party CPU-counting action from JavaScript unit-test jobs.
Changes:
- Removes
SimenB/github-actions-cpu-coressteps andMAXWORKERS. - Uses
nprocdirectly for Jest worker counts.
File summaries
| File | Description |
|---|---|
.github/workflows/unit-test.yml |
Replaces action-provided CPU counts with nproc. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bf4ff72 to
5a2c597
Compare
5a2c597 to
e43a8c8
Compare
e43a8c8 to
cb3af9e
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cb3af9e to
a2528f0
Compare
Part of #82782.
What?
Removes the
SimenB/github-actions-cpu-coresthird-party action dependency fromunit-test.yml, matching upstream trunk's own removal of it.Why?
Upstream trunk removed this dependency in
4d02abd34c61e8bcf30399c219fdccedaf0e8a84(see #78593). The action was only ever used to populate aMAXWORKERSenvironment variable fed into Jest's--maxWorkersflag.nproc, run directly on the runner, provides the exact same value without depending on an external action.This branch (
wp/7.0) still had the dependency in three jobs inunit-test.yml:unit-js,unit-js-date, and the currently-disabledmobile-unit-js. Each had itsSimenB/github-actions-cpu-coresstep (andid: cpu-cores) removed, itsMAXWORKERSenv var line dropped, and its--maxWorkers="$MAXWORKERS"usage switched to--maxWorkers="$(nproc)"directly.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.