Skip to content

Repair wp/7.0 branch Actions: remove SimenB/github-actions-cpu-cores dependency - #82804

Open
desrosj wants to merge 1 commit into
fix-actions-7.0/disable-flaky-test-issue-reportingfrom
fix-actions-7.0/remove-cpu-cores-dependency
Open

desrosj wants to merge 1 commit into
fix-actions-7.0/disable-flaky-test-issue-reportingfrom
fix-actions-7.0/remove-cpu-cores-dependency

Conversation

@desrosj

@desrosj desrosj commented Sep 11, 2026

Copy link
Copy Markdown
Member

Part of #82782.

What?

Removes the SimenB/github-actions-cpu-cores third-party action dependency from unit-test.yml, matching upstream trunk's own removal of it.

Why?

Upstream trunk removed this dependency in 4d02abd34c61e8bcf30399c219fdccedaf0e8a84 (see #78593). The action was only ever used to populate a MAXWORKERS environment variable fed into Jest's --maxWorkers flag. nproc, run directly on the runner, provides the exact same value without depending on an external action.

This branch (wp/7.0) still had the dependency in three jobs in unit-test.yml: unit-js, unit-js-date, and the currently-disabled mobile-unit-js. Each had its SimenB/github-actions-cpu-cores step (and id: cpu-cores) removed, its MAXWORKERS env var line dropped, and its --maxWorkers="$MAXWORKERS" usage switched to --maxWorkers="$(nproc)" directly.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 9cebc6cb-bb28-4b11-a1c8-1c94b86be499

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All affected jobs use Ubuntu runners where nproc is available, preserving existing worker-count behavior.

Pull request overview

Removes an unnecessary third-party CPU-counting action from JavaScript unit-test jobs.

Changes:

  • Removes SimenB/github-actions-cpu-cores steps and MAXWORKERS.
  • Uses nproc directly for Jest worker counts.
File summaries
File Description
.github/workflows/unit-test.yml Replaces action-provided CPU counts with nproc.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@desrosj
desrosj force-pushed the fix-actions-7.0/remove-cpu-cores-dependency branch from bf4ff72 to 5a2c597 Compare September 14, 2026 01:50
@desrosj
desrosj force-pushed the fix-actions-7.0/remove-cpu-cores-dependency branch from 5a2c597 to e43a8c8 Compare September 14, 2026 02:34
@desrosj
desrosj force-pushed the fix-actions-7.0/remove-cpu-cores-dependency branch from e43a8c8 to cb3af9e Compare September 14, 2026 16:42
@desrosj
desrosj marked this pull request as ready for review September 14, 2026 16:57
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj force-pushed the fix-actions-7.0/remove-cpu-cores-dependency branch from cb3af9e to a2528f0 Compare September 14, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants