Skip to content

Disable .NET SDK rollForward in global.json #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Disable .NET SDK rollForward in global.json #236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20dfc92
Initial plan
Copilot Mar 4, 2026
242bcfd
Disable .NET SDK rollForward in global.json
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "8.0.300",
"rollForward": "latestMinor"

@brian-reichle brian-reichle Mar 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTG.Analyzers is built & tested in a GitHub workflow, not on DAT. So the set of installed SDKs is determined by configuration within this repository.

WTG.Analyzers/.github/workflows/build.yaml

Line 27 in 2b23b78

dotnet-version: 8.0.300

So this will only affect people trying to build locally.

@brian-reichle brian-reichle Mar 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is a public repository.

@yaakov-h yaakov-h Mar 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these days we can take out lines 26 and 27 from the GitHub Actions workflow, and actions/setup-dotnet will act based upon the root global.json by default.

@brian-reichle brian-reichle Mar 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also lines 53-54. Then release.yaml lines 28-29.

Should probably remove them just so we don't have so may places to update when updating the SDK.

@brettshearer brettshearer Mar 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to restrict to only those repositories based on QGL/DAT too.

"rollForward": "disabled"
}
}