fix: 修复 Windows 插件安装与 service 测试 - #6342
Open
mordekasiser wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Windows 下
go test ./internal/service暴露两类跨平台缺陷:zip.OpenReader打开上传临时包,ZIP 句柄直到函数返回才关闭;安装流程在句柄仍打开时执行os.Rename,Windows 返回文件占用错误,真实插件安装和 4 个安装器测试失败。1nsTTL 触发过期,依赖连续两次系统时钟读数不同;Windows 时钟分辨率会让测试间歇性无法触发后台刷新。修复
验证
go test -count=1 ./internal/service通过,耗时 127.790 秒。go vet ./internal/service通过。git diff --check通过。当前 Windows 工具链未启用 CGO,未运行
go test -race。