fix(openai): track HTTP/2 stream body failures - #6326
Open
HypoxanthineOvO wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign, please reply with the following comment:
You only need to sign once — it will be valid for all your future contributions to this project. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The HTTP/2 compatibility fallback currently records success as soon as
http.Client.Doreturns response headers. For SSE responses, the body can faillater with errors such as
http2: client connection lost. Each affectedrequest therefore clears the failure window before its body fails, and the body
failure is never reported to the fallback circuit.
The proxy stream circuit has a related concurrency race: any successful stream
deletes the circuit entry, including a request that started before concurrent
failures tripped the quarantine.
Fix
Generic
unexpected EOFis intentionally not classified as an HTTP/2compatibility error at this layer because it can also be observed after a valid
terminal SSE event. The higher-level stream circuit keeps the protocol context
needed to distinguish those cases.
Tests
go test ./internal/repository -count=1go test ./internal/service -count=1Regression coverage includes repeated body read failures, a healthy request
resetting a pre-trip failure window, stale concurrent successes, generic
unexpected EOF, quarantine TTL behavior, terminal events, and cancellation.