fix(grok): preserve Responses vision tool output images - #6325
Open
251392463 wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA. ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
251392463
force-pushed
the
fix/grok-responses-vision-tool-output
branch
from
August 28, 2026 07:38
0050563 to
b4b5371
Compare
Author
|
公司内部环境验证,问题已经解决了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
function_call_output.imagesinput_imageparts from structuredfunction_call_output.outputarraysfunction_call_output.outputas text while lifting media into a following user message in call orderRoot cause
Grok Build
1.0.5can return localread_fileresults as either top-levelimages[]or structuredoutput[]parts. The Grok Responses sanitizer previously reduced every tool result to a string and silently discarded those images (or serialized image data as ordinary text). The next continuation therefore reached xAI without the vision context that the client had supplied, which can lead to an unrelated continuation as described in #6185.This change keeps the xAI-compatible textual tool output and sends the extracted images as standard Responses
input_imagecontent immediately after the consecutive tool outputs, preserving per-call attribution and order.Validation
go test ./internal/service -run 'TestSanitizeGrokResponsesModelInput|TestPatchGrokResponsesBody.*Images' -count=1go test -tags=unit ./internal/service ./internal/pkg/apicompat -count=1go vet -tags=unit ./internal/serviceFixes #6185