Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description, Motivation, and Context
Fixes a Mercury reconnect race that can leave a replacement WebSocket connected but unable to receive events.
Each Mercury connection now owns its listener, heartbeat loop, pong handler, and lifecycle channels. A stale connection cannot clear the connected state of a newer connection or trigger a second reconnect. WebSocket writes are also serialized across authentication, heartbeat, and shutdown paths.
This preserves the existing public API and automatic reconnect behavior while making reconnect state generation-safe.
📖 Issues and Related PRs
No issue or related PR was supplied.
🖼 Screenshots
Not applicable; this change does not modify the UI.
🌮 How This Was Tested
Added a regression test that:
Validation commands:
Required Items Complete
Security
Not applicable. This change does not alter authentication, authorization, credentials, network endpoints, or stored data.