Implement the active custom element constructor map#69639
Merged
webkit-commit-queue merged 1 commit intoJul 18, 2026
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 1e861ff) Details
|
rniwa
reviewed
Jul 17, 2026
rniwa
reviewed
Jul 17, 2026
rniwa
approved these changes
Jul 17, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
annevk
force-pushed
the
eng/Implement-the-active-custom-element-constructor-map
branch
from
July 18, 2026 06:32
1e861ff to
72ac26b
Compare
Collaborator
|
EWS run on current version of this PR (hash 72ac26b) Details |
https://bugs.webkit.org/show_bug.cgi?id=319658 Reviewed by Ryosuke Niwa. Keith Cirkel pointed out that the constructor map as defined did not quite work and also that WebKit did not implement it. This aligns WebKit with the proposed changes to DOM and HTML and also adds some additional test coverage for the gaps: - whatwg/dom#1494 - whatwg/html#12696 Tests: imported/w3c/web-platform-tests/custom-elements/createElement-reentrant-construction.window.html imported/w3c/web-platform-tests/custom-elements/registries/constructor-direct-call-fallback-registry.window.html imported/w3c/web-platform-tests/custom-elements/registries/constructor-reentry-createElement.window.html Canonical link: https://commits.webkit.org/317462@main
webkit-commit-queue
force-pushed
the
eng/Implement-the-active-custom-element-constructor-map
branch
from
July 18, 2026 11:27
72ac26b to
48915d8
Compare
Collaborator
|
Committed 317462@main (48915d8): https://commits.webkit.org/317462@main Reviewed commits have been landed. Closing PR #69639 and removing active labels. |
annevk
deleted the
eng/Implement-the-active-custom-element-constructor-map
branch
July 18, 2026 11:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 mac-apple
48915d8
72ac26b
🧪 mac-AS-debug-wk2🧪 mac-intel-wk2