Skip to content

Implement the active custom element constructor map#69639

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
annevk:eng/Implement-the-active-custom-element-constructor-map
Jul 18, 2026
Merged

Implement the active custom element constructor map#69639
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
annevk:eng/Implement-the-active-custom-element-constructor-map

Conversation

@annevk

@annevk annevk commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

48915d8

Implement the active custom element constructor map
https://bugs.webkit.org/show_bug.cgi?id=319658

Reviewed by Ryosuke Niwa.

Keith Cirkel pointed out that the constructor map as defined did not
quite work and also that WebKit did not implement it.

This aligns WebKit with the proposed changes to DOM and HTML and also
adds some additional test coverage for the gaps:

- whatwg/dom#1494
- whatwg/html#12696

Tests: imported/w3c/web-platform-tests/custom-elements/createElement-reentrant-construction.window.html
       imported/w3c/web-platform-tests/custom-elements/registries/constructor-direct-call-fallback-registry.window.html
       imported/w3c/web-platform-tests/custom-elements/registries/constructor-reentry-createElement.window.html

Canonical link: https://commits.webkit.org/317462@main

72ac26b

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests loading 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 vision-sim 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2 ✅ 🛠 mac-safer-cpp
✅ 🛠 tv ❌ 🧪 mac-site-isolation
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk self-assigned this Jul 17, 2026
@annevk annevk added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Jul 17, 2026
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 17, 2026
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Jul 17, 2026
@annevk
annevk marked this pull request as ready for review July 17, 2026 20:51
@annevk
annevk requested review from cdumez and rniwa as code owners July 17, 2026 20:51
Comment thread Source/WebCore/dom/Document.cpp Outdated
Comment thread Source/WebCore/dom/Document.h Outdated
@webkit-ews-buildbot

This comment was marked as resolved.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 17, 2026
@webkit-ews-buildbot

This comment was marked as resolved.

@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Jul 18, 2026
@annevk
annevk force-pushed the eng/Implement-the-active-custom-element-constructor-map branch from 1e861ff to 72ac26b Compare July 18, 2026 06:32
@annevk annevk added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jul 18, 2026
https://bugs.webkit.org/show_bug.cgi?id=319658

Reviewed by Ryosuke Niwa.

Keith Cirkel pointed out that the constructor map as defined did not
quite work and also that WebKit did not implement it.

This aligns WebKit with the proposed changes to DOM and HTML and also
adds some additional test coverage for the gaps:

- whatwg/dom#1494
- whatwg/html#12696

Tests: imported/w3c/web-platform-tests/custom-elements/createElement-reentrant-construction.window.html
       imported/w3c/web-platform-tests/custom-elements/registries/constructor-direct-call-fallback-registry.window.html
       imported/w3c/web-platform-tests/custom-elements/registries/constructor-reentry-createElement.window.html

Canonical link: https://commits.webkit.org/317462@main
@webkit-commit-queue
webkit-commit-queue force-pushed the eng/Implement-the-active-custom-element-constructor-map branch from 72ac26b to 48915d8 Compare July 18, 2026 11:27
@webkit-commit-queue

Copy link
Copy Markdown
Collaborator

Committed 317462@main (48915d8): https://commits.webkit.org/317462@main

Reviewed commits have been landed. Closing PR #69639 and removing active labels.

@webkit-commit-queue
webkit-commit-queue merged commit 48915d8 into WebKit:main Jul 18, 2026
@webkit-commit-queue webkit-commit-queue removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jul 18, 2026
@annevk
annevk deleted the eng/Implement-the-active-custom-element-constructor-map branch July 18, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants