Skip to content

test PR do not merge {descriptive title of change} - #15

Open
isabellaphan06 wants to merge 3 commits into
mainfrom
RPM_SENSOR
Open

test PR do not merge {descriptive title of change}#15
isabellaphan06 wants to merge 3 commits into
mainfrom
RPM_SENSOR

Conversation

@isabellaphan06

Copy link
Copy Markdown

details on everyrthibg and what i did to test

@XanderHayhoe

Copy link
Copy Markdown
Member

Hey! This PR looks great.
When you get the chance, could you try refactoring the logic we need to do the rpm sensor work into a single callable function? Keep you global variables and such the way they are; just try to refactor it as much as possible while maintaining functionality. This will make integration much much easier in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants