Fix switches with both types and enum values - #612
Merged
jaskarth merged 4 commits intoAug 18, 2026
Conversation
|
This fixes the decompilation entirely failing with NoiseChunk, but the output is missing the class label and so isn't re-compilable |
jaskarth
added
Subsystem: Statement Structure
jaskarth
reviewed
Aug 18, 2026
jaskarth
left a comment
jaskarth
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for this PR! The logic looks good, I just have two comments here.
| public TextBuffer toJava(int indent) { | ||
| TextBuffer buf = new TextBuffer(); | ||
|
|
||
| if (wasCondy) { |
Member
There was a problem hiding this comment.
It would be good to keep this. If this shows up in switch specific code, could a flag be set to suppress it when it's resugared?
| VALUE1, | ||
| VALUE2; | ||
| } | ||
| public String test7(Object o) { |
Member
There was a problem hiding this comment.
It'd be good to add a test that uses a when clause, to make sure that those work with this too.
jaskarth
approved these changes
Aug 18, 2026
jaskarth
left a comment
jaskarth
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks again for this PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes switches with both types and enum values