Add support for new Eclipse string-switch variant - #601
Merged
jaskarth merged 14 commits intoJul 11, 2026
Merged
Conversation
aoqia194
changed the title
aoqia194
commented
Jun 22, 2026
aoqia194
marked this pull request as draft
June 22, 2026 13:48
aoqia194
marked this pull request as ready for review
June 25, 2026 22:58
Contributor
Author
|
I am opening this back up for review as I've finally found and fixed the mistakes I've done! (thanks Kropp for the help with the desync and validation issues) |
jaskarth
added
Type: Enhancement
this check was used before i did case merging. since case merging is being performed now, i believe it's not necessary anymore.
i no longer know what causes merged switch types, so i cannot create a valid test case for them
also changes the cast to a safe check just in case?
this check was used before i did case merging. since case merging is being performed now, i believe it's not necessary anymore.
these never execute on our entire test suite
i previously assumed that these edges would always be explicit. i was wrong, so here we are!
aoqia194
force-pushed
the
feat/eclipse-str-switch
branch
from
July 11, 2026 18:19
5b2d15c to
abd4394
Compare
the recent changes from develop/1.13.0 have fixed this issue
jaskarth
approved these changes
Jul 11, 2026
jaskarth
left a comment
jaskarth
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thank you for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133
I've done some minor refactoring in this as well, so I apologise in advance. Most of those are just variable renames or deleting redundant comments.
Also fixes some minor bugs that caused other string-switches to fail the beautification! (what is this called lmao)