PR for next LTS release (0.68.7)#2330
Open
vrutkovs wants to merge 6 commits into
Open
Conversation
5d46f05 to
f10ee67
Compare
Signed-off-by: immanuwell <pchpr.00@list.ru>
Contributor
There was a problem hiding this comment.
1 issue found across 6 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:16">
P2: Custom agent: **Changelog Review Agent**
Changelog entry describes internal implementation detail (adding a struct field) instead of a user-visible fix. The rule requires user-centric explanations and prohibits describing internal implementation details.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
|
|
||
| ## tip | ||
|
|
||
| * BUGFIX: [vmanomaly](https://docs.victoriametrics.com/operator/resources/vmanomaly/): add missing `scatter_infer_jobs` field to the periodic scheduler config struct. See [#2328](https://github.com/VictoriaMetrics/operator/issues/2328). |
Contributor
There was a problem hiding this comment.
P2: Custom agent: Changelog Review Agent
Changelog entry describes internal implementation detail (adding a struct field) instead of a user-visible fix. The rule requires user-centric explanations and prohibits describing internal implementation details.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/CHANGELOG.md, line 16:
<comment>Changelog entry describes internal implementation detail (adding a struct field) instead of a user-visible fix. The rule requires user-centric explanations and prohibits describing internal implementation details.</comment>
<file context>
@@ -13,6 +13,8 @@ aliases:
## tip
+* BUGFIX: [vmanomaly](https://docs.victoriametrics.com/operator/resources/vmanomaly/): add missing `scatter_infer_jobs` field to the periodic scheduler config struct. See [#2328](https://github.com/VictoriaMetrics/operator/issues/2328).
+
## [v0.68.6](https://github.com/VictoriaMetrics/operator/releases/tag/v0.68.6)
</file context>
Suggested change
| * BUGFIX: [vmanomaly](https://docs.victoriametrics.com/operator/resources/vmanomaly/): add missing `scatter_infer_jobs` field to the periodic scheduler config struct. See [#2328](https://github.com/VictoriaMetrics/operator/issues/2328). | |
| * BUGFIX: [vmanomaly](https://docs.victoriametrics.com/operator/resources/vmanomaly/): allow configuring `scatter_infer_jobs` in the periodic scheduler. Previously this option was missing and its value was silently ignored. See [#2328](https://github.com/VictoriaMetrics/operator/issues/2328). |
ff2a385 to
d09a187
Compare
….12.2 (#2149) * chore(deps): update module github.com/golangci/golangci-lint/v2 to v2.12.2 * chore: use reflect.Pointer to fix `inline: Constant reflect.Ptr should be inlined` --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
a53bc08 to
a78e807
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.