Skip to content

fix: Tempo search API returns incorrect startTimeUnixNano and overflows durationMs #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
szibis wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: Tempo search API returns incorrect startTimeUnixNano and overflows durationMs #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45497b3
fix: Tempo search API returns incorrect startTimeUnixNano and overflo…
szibis May 14, 2026
8f7e535
test: add tests for Tempo search startTimeUnixNano and durationMs
szibis May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions app/vtselect/traces/tempo/tempo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@ func summarySearchTracesResult(ctx context.Context, rows []*tracecommon.Row, lim
for _, row := range rows {
var traceID, serviceName, spanName, parentSpanID string
var startTimeUnixNano, endTimeUnixNano int64
var hasStart, hasEnd bool
var err error
for _, field := range row.Fields {
switch field.Name {
Expand All @@ -444,11 +445,13 @@ func summarySearchTracesResult(ctx context.Context, rows []*tracecommon.Row, lim
if err != nil {
return nil, err
}
hasStart = true
case otelpb.EndTimeUnixNanoField:
endTimeUnixNano, err = strconv.ParseInt(field.Value, 10, 64)
if err != nil {
return nil, err
}
hasEnd = true
default:
continue
}
Expand All @@ -469,8 +472,12 @@ func summarySearchTracesResult(ctx context.Context, rows []*tracecommon.Row, lim
}

summary.traceID = traceID
summary.startTimeUnixNano = min(summary.startTimeUnixNano, startTimeUnixNano)
summary.endTimeUnixNano = max(summary.endTimeUnixNano, endTimeUnixNano)
if hasStart {
summary.startTimeUnixNano = min(summary.startTimeUnixNano, startTimeUnixNano)
}
if hasEnd {
summary.endTimeUnixNano = max(summary.endTimeUnixNano, endTimeUnixNano)
}
// if it's the root span
if parentSpanID == "" {
summary.rootServiceName = serviceName
Expand All @@ -482,6 +489,9 @@ func summarySearchTracesResult(ctx context.Context, rows []*tracecommon.Row, lim

resultList := make([]traceSummary, 0, len(traceMap))
for _, summary := range traceMap {
if summary.startTimeUnixNano == math.MaxInt64 {
summary.startTimeUnixNano = 0
}
resultList = append(resultList, summary)
}
return resultList, nil
Expand Down
2 changes: 1 addition & 1 deletion app/vtselect/traces/tempo/tempo.qtpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
"traceID":{%q= summary.traceID %},
"rootServiceName":{%q= summary.rootServiceName %},
"rootTraceName":{%q= summary.rootTraceName %},
"startTimeUnixNano":{%dl= summary.startTimeUnixNano %},
"startTimeUnixNano":"{%dl= summary.startTimeUnixNano %}",
"durationMs":{%dl= (summary.endTimeUnixNano - summary.startTimeUnixNano) / 1e6 %},
"spanSets": []
}
Expand Down
Loading