app/vlagent/remotewrite: introduce VictoriaLogs transformations language#1508
app/vlagent/remotewrite: introduce VictoriaLogs transformations language#1508vadimalekseev wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 33 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
vadimalekseev
force-pushed
the
vlt
branch
5 times, most recently
from
1e493dd to
e300516
Compare
vadimalekseev
force-pushed
the
vlt
branch
5 times, most recently
from
39f6deb to
c3556c4
Compare
There was a problem hiding this comment.
4 issues found and verified against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| fields := rows[0] | ||
| for i := range fields { | ||
| name := br.addValue(fields[i].Name) | ||
| name := getCanonicalColumnName(fields[i].Name) |
There was a problem hiding this comment.
These changes are not related to log transformations, but without them, my tests fail.
vadimalekseev
force-pushed
the
vlt
branch
3 times, most recently
from
8ad3249 to
e286231
Compare
| timestamps = br.getTimestamps() | ||
| } else { | ||
| // Slow path: the _time column was overwritten or removed, initialize it again. | ||
| br.initTimestamps() |
There was a problem hiding this comment.
Modifying br here by calling initTimestamps is a questionable approach - no other pipe does this. However, it simplifies the code and avoids duplicating logic.
| // | ||
| // It stops calling visitFunc on the remaining filters as soon as visitFunc returns true. | ||
| // It returns the result of the last visitFunc call. | ||
| func visitFilterRecursiveForPipe(p pipe, visitFunc func(f filter) bool) bool { |
There was a problem hiding this comment.
This code was written in the hope that it would be replaced with supporting relative time filters in VictoriaLogs transformations.
1 participant
Documentation and syntax: https://github.com/VictoriaMetrics/VictoriaLogs/blob/vlt/docs/victorialogs/vlagent/transformations.md
Closes #858