app/vlagent: implement /targets page#1401
Open
vadimalekseev wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 16 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/victorialogs/CHANGELOG.md">
<violation number="1" location="docs/victorialogs/CHANGELOG.md:29">
P1: Custom agent: **Technical Writer Review Agent**
Changelog entry contains multiple typos and a grammar error: 'shold' (should), 'vlanget' (vlagent), and incorrect verb form 'should improves' (should improve) on the same line</violation>
</file>
<file name="app/vlagent/filecollector/processor.go">
<violation number="1" location="app/vlagent/filecollector/processor.go:80">
P1: `/targets` can panic when `-fileCollector.fileField` is set to a custom name, because debug info no longer guarantees a `file` field.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
696f5c3 to
5803c0f
Compare
This improves the user experience when using vlanget to collect Kubernetes logs and files. This commit uses the bootstrap CSS library for the VictoriaMetrics navbar, ensuring a consistent look and feel similar to vmagent. While the overall design currently differs from vmagent, we can align them further later if required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the user experience when using vlanget to collect Kubernetes logs and files.
This commit uses the bootstrap CSS library for the VictoriaMetrics navbar, ensuring a consistent look and feel similar to vmagent. While the overall design currently differs from vmagent, we can align them further later if required.
This PR increases binary size of vlagent from 18648322 bytes to 19015666 (plus ~300 KiB).
Updates #1391
See the
/targetsweb page screenshots bellow: