ci: bump pinned @junobuild/cli to 0.15.5 (cli#515 fix) - #554
Merged
Merged
Conversation
@junobuild/cli@0.15.5 includes junobuild/cli#515, which fixes the build not including the generated Rust custom-functions module in the wasm32-wasip1 satellite build — the bug that shipped satellites with no custom query methods (IC0536 'no query method app_get_profile'). Bumps the two direct CLI pins (checks.yml satellite-schema, e2e.yml). The action-based workflows (upgrade.yml/publish.yml via junobuild/juno-action@full) already pick up the fix automatically — @Full now resolves to image 0.7.4, which bundles cli 0.15.5 (junobuild/juno-action#110).
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned @junobuild/cli version used by CI workflows to pick up the upstream fix for missing custom query methods in the wasm32-wasip1 satellite build (junobuild/cli#515), which previously caused production sign-in failures.
Changes:
- Bump the globally installed
@junobuild/cliin the E2E workflow from0.15.4to0.15.5. - Bump the globally installed
@junobuild/cliin thesatellite-schemachecks workflow from0.15.4to0.15.5.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/e2e.yml | Updates the pinned Juno CLI version used during E2E runs to include the upstream satellite build fix. |
| .github/workflows/checks.yml | Updates the pinned Juno CLI version used for satellite-schema regeneration/drift checking to match the fixed CLI release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The CI satellite build was shipping with no custom query methods (
IC0536 — Canister has no query method 'app_get_profile'), breaking production sign-in. Root cause was a juno CLI bug — the generated Rust custom-functions module was not included in thewasm32-wasip1satellite build. Fixed upstream in junobuild/cli#515, released in@junobuild/cli@0.15.5.Changes
Bump the two direct CLI pins from
0.15.4→0.15.5:checks.yml(satellite-schema) ande2e.yml.The action-based workflows need no change —
upgrade.yml/publish.ymlusejunobuild/juno-action@full, which now resolves to image0.7.4bundling cli0.15.5(junobuild/juno-action#110), so they already pick up the fix.Tests
The
e2ejob on this PR is the field test: with0.15.5the satellite build now embeds the custom functions, so the signed-in flows (auth,homepage, signed-innavigation) that were failing withgetProfile()errors should pass. Note: a separate, pre-existing[404] GET /socialrouting failure and the 45-min e2e timeout are tracked elsewhere (fix/e2e-bounded-networkidle-and-timeout) and are out of scope here.satellite-schemashould stay green (and now actually regenerates against the fixed build).Follow-up (not in this PR):
checks.yml's inline comment above the install still references the old (incorrect) "bindgen →service : {}" rationale and could be trimmed; left untouched here to keep the diff to the version bump.