chore(icdc-core): sync bindings and bump version to v0.1.8 - #1202
Open
AntonioVentilii wants to merge 2 commits into
Open
AntonioVentilii wants to merge 2 commits into
AntonioVentilii wants to merge 2 commits into
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
🟡 Not ready to approve
The new required due field in RegistryDid.ListSeriesParams will break existing TypeScript call sites that construct this params object unless they are updated in the same PR.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Automated sync of the app’s generated Candid bindings with upstream AntonioVentilii/icdc-core release v0.1.8, updating the local interface surface for the registry and clearing canisters.
Changes:
- Bumped the upstream
icdc-coreversion used by the build/download script tov0.1.8. - Updated
registrybindings to support a newduefilter onlist_series_withviaListSeriesParams. - Updated
clearingbindings to add a new batch query endpoint for settlement-status lookup (list_series_settlement_statuses).
File summaries
| File | Description |
|---|---|
| src/declarations/registry/registry.idl.js | Adds due: opt bool to ListSeriesParams in the JS IDL factory. |
| src/declarations/registry/registry.certified.idl.js | Mirrors the due field addition for the certified IDL factory. |
| src/declarations/registry/registry.did | Documents and adds the due filter to ListSeriesParams in the Candid interface. |
| src/declarations/registry/registry.d.ts | Exposes due on ListSeriesParams in generated TypeScript types. |
| src/declarations/clearing/clearing.idl.js | Adds new param/return record types and the list_series_settlement_statuses query method. |
| src/declarations/clearing/clearing.certified.idl.js | Mirrors the new batch settlement-status method in the certified IDL factory. |
| src/declarations/clearing/clearing.did | Adds Candid types and service method for list_series_settlement_statuses. |
| src/declarations/clearing/clearing.d.ts | Exposes the new method and associated types in generated TypeScript types. |
| scripts/build/download.icdc.common.sh | Bumps ICDC_CORE_VERSION to v0.1.8. |
Review details
- Files reviewed: 7/9 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
AntonioVentilii
force-pushed
the
bot-update-icdc-core
branch
from
August 10, 2026 04:37
f818600 to
be79ea7
Compare
github-actions
Bot
force-pushed
the
bot-update-icdc-core
branch
from
August 17, 2026 04:20
e14c069 to
a5169e4
Compare
AntonioVentilii
added a commit
that referenced
this pull request
Aug 19, 2026
# Motivation `update-icdc-core.yml` opened its sync PR with `secrets.RELEASE_PLEASE_PAT || secrets.GITHUB_TOKEN`. `RELEASE_PLEASE_PAT` has never existed on this repo (`gh secret list` shows only `RELEASE_BOT_PRIVATE_KEY`, `JUNO_TOKEN`, `FLY_API_TOKEN_WEB2_BACKEND`, `FLY_API_TOKEN_WEB2_WEB`), so it always fell back to `GITHUB_TOKEN`. That breaks the workflow in two ways. First, a PR created with `GITHUB_TOKEN` does not trigger further workflow runs. #1202 has been open since 2026-08-03 with only the 3 CodeQL checks (those come from code scanning default setup, not from `Checks`), so `checks-pass` never reports and the main ruleset blocks it permanently. Second, since the move to the ViciApp org the workflow no longer opens a PR at all. The 2026-08-17 scheduled run pushed the branch and then failed with `GitHub Actions is not permitted to create or approve pull requests`, because `can_approve_pull_request_reviews` is `false` at both repo and org level. `GITHUB_TOKEN` is subject to that restriction; a GitHub App installation token is not. # Changes - The sync PR is now opened as the `vici-release-bot` GitHub App, using the same `actions/create-github-app-token` step and app id that `release-please.yml` already uses. This fixes both failures: the app token can create PRs under the current org setting, and PRs it creates do trigger `Checks`. The installation demonstrably has `pull-requests: write` and `contents: write`, since release PR #1239 was authored by `app/vici-release-bot`. - No fork guard is needed here, unlike the `format` job in `checks.yml`. This workflow only runs on `schedule` and `workflow_dispatch`, always from `main`. Deliberately out of scope: `e2e.yml` passes `secrets.GITHUB_TOKEN` to the same `create-pr` action for `bot-e2e-update-snapshots`, so it hits the identical pair of problems and now hard-fails on the org setting. The same fix applies, but that path is only reachable on `main` after an e2e snapshot drift and deserves its own PR. # Tests - `grep -rn RELEASE_PLEASE_PAT .github/` returns no matches. - `npx prettier --check .github/workflows/update-icdc-core.yml` passes. - `actionlint` on the file before and after the change: both exit 0 with empty output, so no new diagnostics. - Not verifiable pre-merge: the workflow only runs on `schedule` / `workflow_dispatch`. The proof is a post-merge `workflow_dispatch` opening a PR authored by `vici-release-bot` with a `Checks` run attached.
vici-release-bot
Bot
force-pushed
the
bot-update-icdc-core
branch
from
August 24, 2026 04:50
a5169e4 to
090bacb
Compare
vici-release-bot
Bot
force-pushed
the
bot-update-icdc-core
branch
2 times, most recently
from
September 7, 2026 09:07
1a6808d to
4d9d79f
Compare
vici-release-bot
Bot
force-pushed
the
bot-update-icdc-core
branch
from
September 14, 2026 09:43
427ab94 to
720e6a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync with upstream
AntonioVentilii/icdc-core.ICDC_CORE_VERSIONinscripts/build/download.icdc.common.shto the latest release (v0.1.8).src/declarations/**vianpm run did(which also runs format + lint).Opened automatically by the
Update icdc-coreworkflow. Review the regenerated.didsurface before merging.