drm: Ensures that we can use the DRM format on the vulkan device#2243
drm: Ensures that we can use the DRM format on the vulkan device#2243marysaka wants to merge 1 commit into
Conversation
|
Shouldn't we just check if the format can do STORAGE? |
Gamescope now select the DRM format by checking if the vulkan driver can support those formats with the required image usage bits. This fixes NVK where nouveau kernel module reports support for XRGB2101010 and ARGB2101010 but the hardware cannot support those formats as image storage. Signed-off-by: Mary Guillemard <mary@mary.zone>
254d80a to
2941d4a
Compare
Should be good now, I initially thought it would be way harder than that |
|
Vulkan-specific code should probably be moved into a function of its own in There is very similar code in the |
Looking at it more, couldn't we just base it on If we modify Of course What do you think about that approach? |
|
Closes #1717 |
|
Tested this on an RTX 5070 (GB205) with nouveau/NVK, where I was hitting exactly the problem this PR describes. Without this PR, the embedded session ( With this PR applied on top of master (73950ef), the session starts cleanly and falls back to XR24 as intended. Steam Deck UI comes up and works. Setup: Arch Linux, kernel 7.1.3, Mesa/NVK 26.1.4, nouveau with GSP 570.144 and Full disclosure: I'm a hobbyist and I debugged this with help from an AI assistant, but the test itself is a real boot on real hardware, crash-loop without the patch, working session with it. Happy to re-test future revisions of this PR on this machine. |
Gamescope now select the DRM format by checking if the vulkan driver
can support those formats with the required image usage bits.
This fixes NVK where nouveau kernel module reports support for
XRGB2101010 and ARGB2101010 but the hardware cannot support those
formats as image storage