Skip to content

FIX: Inset the search field in the "Add supported device" popup so it no longer sits flush against the popup's left edge [UUM-150217] #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pauliusd01 wants to merge 4 commits into
base: develop
Choose a base branch
from
+6 −0
Open

FIX: Inset the search field in the "Add supported device" popup so it no longer sits flush against the popup's left edge [UUM-150217] #2478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c181277
FIX: Inset the search field in the "Add supported device" popup so it…
Pauliusd01 Aug 20, 2026
060a266
FIX: Tune search-field inset to 8px and drop redundant comment [UUM-1…
Pauliusd01 Aug 20, 2026
7088a81
FIX: Also inset the Listen block in PickControl mode [UUM-150217]
Pauliusd01 Aug 20, 2026
383dcde
FIX: Match the Listen block inset to the search field at 8px [UUM-150…
Pauliusd01 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Packages/com.unity.inputsystem/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Fixed

- Fixed the search field in the "Add supported device" popup (Input System Package Settings > Supported Devices > "+") drawing flush against the popup's left edge with no left margin, unlike its right-side spacing; it is now inset to match [UUM-150217](https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-150217)
- Fixed the "Supported Devices" list in the Input System Package Settings sitting flush against the panel edge with no left/right margin, unlike the surrounding fields; it is now inset to line up with the other settings controls [UUM-150207](https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-150207)
- Fixed the Inspector help button for a selected `.inputactions` asset ("Open Reference for Input Action Importer") opening a missing documentation page; it now links to the Action Assets manual page [UUM-149518](https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-149518)
- Fixed an `OverflowException` when creating a control scheme (or other named item) whose all-numeric name exceeds `Int32.MaxValue`, which previously discarded the entered name and fell back to the default [UUM-145766](https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-145766)
Expand Down
5 changes: 5 additions & 0 deletions ...ages/com.unity.inputsystem/InputSystem/Editor/ControlPicker/InputControlPickerDropdown.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,7 @@
// When picking controls, have a "Listen" button that allows listening for input.
if (m_Owner.m_Mode == InputControlPicker.Mode.PickControl)
{
GUILayout.Space(8f);

Check warning on line 578 in Packages/com.unity.inputsystem/InputSystem/Editor/ControlPicker/InputControlPickerDropdown.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/ControlPicker/InputControlPickerDropdown.cs#L578 

Added line #L578 was not covered by tests
using (new EditorGUILayout.VerticalScope(GUILayout.MaxWidth(50)))
{
GUILayout.Space(4);
Expand All @@ -598,6 +599,10 @@
isListening = isListeningNew;
}
}
else
{
GUILayout.Space(8f);
}

Check warning on line 605 in Packages/com.unity.inputsystem/InputSystem/Editor/ControlPicker/InputControlPickerDropdown.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/ControlPicker/InputControlPickerDropdown.cs#L603-L605 

Added lines #L603 - L605 were not covered by tests

////FIXME: the search box doesn't clear out when listening; no idea why the new string isn't taking effect
EditorGUI.BeginDisabledGroup(isListening);
Expand Down
Loading